527201 - Private MathML attributes should not be accessible from DOM

Status: RESOLVED FIXED

(Core :: MathML, defect, P5)

Description

[Frédéric Wang Nélar]

Attachment: Testcase

MathML use several private attributes to implement "columnalign", "columnline", "rowalign", "rowline" (mtable attributes) and "fontstyle" (in particular to make <mi>x</mi> italic). They are used to apply CSS style via mathml.css. These attributes are currently accessible from DOM while they are not standard.
	
	I try to fix bug 475518 to see whether following the right syntax _moz* helps, but apparently it does not work.
	
	See also http://groups.google.fr/group/mozilla.dev.tech.mathml/browse_thread/thread/fd3e7defcdfb2b4f

Comment 1

[Frédéric Wang Nélar]

(In reply to comment #0)
> Created attachment 410943 [details]
> Testcase

It seems that this bug is fixed on trunk. At least, the private attributes are no longer caught by the testcase...

Comment 2

[Henri Sivonen (:hsivonen)]

Attachment: Mochitest patch for revealing _moz- attributes when running the html5lib test suite

There are still 12 test cases in the html5lib test suite that show this problem. E.g. <!DOCTYPE html><body><table><math><mi>foo</mi></math></table>

Attaching a patch that reveals these when running
parser/htmlparser/tests/mochitest/test_html5_tree_construction_part2.html

Comment 4

[Frédéric Wang Nélar]

Attachment: Testcase

Update the reduced testcase.

Comment 5

[Frédéric Wang Nélar]

(In reply to Frédéric Wang (:fredw) from comment #4)
> Created attachment 490486 [details]
> Testcase
> 
> Update the reduced testcase.

Note: the test is not valid MathML because rowalign and columnalign attributes are reversed. But it detects the private _moz attributes anyway.

Comment 6

[Frédéric Wang Nélar]

https://tbpl.mozilla.org/?tree=Try&rev=51ab041e5ec1

Comment 7

[Frédéric Wang Nélar]

Attachment: Patch V2

Comment 8

[Frédéric Wang Nélar]

Comment on attachment 8347313 [details] [diff] [review]
Patch V2

After bugs 731667 and 114365, all the private _moz attributes have been removed. So I believe this patch can now be taken.

Comment 9

[Frédéric Wang Nélar]

https://tbpl.mozilla.org/?tree=Try&rev=872a4d156e59

Comment 10

[Henri Sivonen (:hsivonen)]

Comment on attachment 8347313 [details] [diff] [review]
Patch V2

Awesome! Thank you.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc7b5f21be2c

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc7b5f21be2c