527343 - Switch about:crashes to use :-moz-locale-dir

Status: RESOLVED INVALID

(Toolkit :: Crash Reporting, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: Fix

Apparently crashes.xhtml was written before :-moz-locale-dir, but landed after it, so it didn't get changed over when all the other chromedir things were replaced.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 411059 [details] [diff] [review]
Fix

> th {
>   text-align: left;
>   white-space: nowrap;
> }
>-th[chromedir="rtl"] {
>+th:-moz-locale-dir(rtl) {
>   text-align: right;
> }

This should just use text-align:start.

Comment 2

[Phil Ringnalda (:philor)]

Heh. I didn't even look at what I was changing.

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/41938f9ac546

Comment 4

[Neil Deakin]

Except that -moz-locale-dir is only implemented for XUL documents, so this will break rtl for this page.

Comment 5

[(no longer active)]

Yes, this should probably be backed out and WONTFIXed.

Comment 6

[Phil Ringnalda (:philor)]

Yup, backed out in http://hg.mozilla.org/mozilla-central/rev/729e58272fb1