Switch about:crashes to use :-moz-locale-dir

RESOLVED INVALID

Status

()

RESOLVED INVALID
9 years ago
9 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 411059 [details] [diff] [review]
Fix

Apparently crashes.xhtml was written before :-moz-locale-dir, but landed after it, so it didn't get changed over when all the other chromedir things were replaced.
Attachment #411059 - Flags: review?(dao)

Updated

9 years ago
Attachment #411059 - Flags: review?(dao) → review+
Comment on attachment 411059 [details] [diff] [review]
Fix

> th {
>   text-align: left;
>   white-space: nowrap;
> }
>-th[chromedir="rtl"] {
>+th:-moz-locale-dir(rtl) {
>   text-align: right;
> }

This should just use text-align:start.
(Assignee)

Comment 2

9 years ago
Heh. I didn't even look at what I was changing.
(Assignee)

Comment 3

9 years ago
http://hg.mozilla.org/mozilla-central/rev/41938f9ac546
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Except that -moz-locale-dir is only implemented for XUL documents, so this will break rtl for this page.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 5

9 years ago
Yes, this should probably be backed out and WONTFIXed.
(Assignee)

Comment 6

9 years ago
Yup, backed out in http://hg.mozilla.org/mozilla-central/rev/729e58272fb1
Status: REOPENED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.