527370 - Rename objects/properties to match File API spec

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

There are two naming differences between our file api implementation and the latest spec drafts: The FileRequest object in our implementation is called FileReader in the spec, and the .response property is called .result.

The attached patch fixes both of these.

I should note that there should be no cause for concern that the spec will change significantly any further. We knew that these names might change when we did the initial landing, and since these names have been proposed to the WG, no dissenting feedback has been received.

The controversial parts of the spec are parts that we don't yet implement (intentionally).

Note, I didn't change the iid for the interface since it's binary compatible with the old interface.

Don't know if this qualifies as an interface change or not, but I asked for sr just in case.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 411091 [details] [diff] [review]
Patch to fix

On second thought, sr seems excessive for something that is a search'n'replace patch.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 411091 [details] [diff] [review]
Patch to fix

Do we want this change to 1.9.2? Then sr would be good.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #0)
> Note, I didn't change the iid for the interface since it's binary compatible
> with the old interface.
I don't understand this. You do change the interface name and its iid.
And what is binary compatible with what?

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 411091 [details] [diff] [review]
Patch to fix

sr=jst, and yeah, the IID did change. I'm fine either way though, since the new interface is binary compatible with the old one in this case.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hrm.. I guess I forgot to rediff after revierting the iid change.

Though it doesn't make much of a practical difference because the contract and CID changed, so binary compat is broken there anyway. So I'll keep the iid change since that's what got reviewed.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in to trunk

http://hg.mozilla.org/mozilla-central/rev/85dc46c47d7f

Comment 7

[Johnny Stenback (:jst)]

Let's get this in for 1.9.2 so developers don't need to fight this any longer than necessary.

Comment 8

[Johnny Stenback (:jst)]

Jonas, can you land this on 1.9.2 asap?

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Some more renames

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Some more renames v1.01

Fix error in test

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Pushed second fix to trunk:

http://hg.mozilla.org/mozilla-central/rev/a0c008161bd3

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This was fixed on the 1.9.2 branch as well on monday:

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/2ff5b2bbc4d8
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/8bc9eba781ea
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/13cf65d3c6c7

Comment 14

[Eric Shepherd [:sheppy]]

Is there a bug for remaining differences between our implementation and the spec? For instance, our implementation of FileException has totally different values than the spec's.

Comment 15

[Arun Ranganathan]

For FileException: Bug 530212
For FileError: Bug 530210

Comment 16

[Eric Shepherd [:sheppy]]

Documentation has been added. There are a few tweaks that will happen to add links to blog posts Paul is working on, but it's essentially done.

https://developer.mozilla.org/en/Using_files_from_web_applications
https://developer.mozilla.org/en/DOM/FileList
https://developer.mozilla.org/en/DOM/File
https://developer.mozilla.org/en/DOM/FileReader
https://developer.mozilla.org/en/DOM/FileError