527374 - Add a "go to my favorites" link in the extension

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Suneel]

Please add a "go to my favorites" link in the Favorites menu underneath random selection.

Comment 1

[Juan Manuel Rodriguez Alvardo]

Attachment: proposed patch for "go to my favorites" link

Added a menu option to "Go To My Favorites" underneath the random menu item.

IMPORTANT NOTE:
The added string requires localization!

Comment 2

[Jose E. Bolanos]

Comment on attachment 411259 [details] [diff] [review]
proposed patch for "go to my favorites" link

1)

+ let goToMyFavoritesURL = this._siteURL + "gallery/All/Favorites";

I think you can spare this var and just write inline like it's done a couple of lines above, like:
 item.setAttribute("oncommand",      "PersonaController.openURLInTab('" +
this._siteURL +
"galler/All/Favorites')");

2)
Perhaps the string entry should be named favoritesGoTo or something like that, to keep the favorites mini-naming convention intact.

Comment 3

[Juan Manuel Rodriguez Alvardo]

Attachment: proposed patch for "go to my favorites" link v2

New patch including the improvements suggested by Jose.

Comment 4

[Jose E. Bolanos]

Comment on attachment 411293 [details] [diff] [review]
proposed patch for "go to my favorites" link v2

Looks good, thanks.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 411293 [details] [diff] [review]
proposed patch for "go to my favorites" link v2

This looks good.  Just a couple minor issues:

1. Lower-case the word "to" in the label, per the capitalization style "capitalization of all words, except for internal articles, prepositions, and conjunctions" <http://en.wikipedia.org/wiki/Title_case#Headings_and_publication_titles>, which is what we use in Personas for labels.

2. Append an ellipsis to the label, since the command opens a separate interface.

r=myk with these changes.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Regarding the changes I requested in comment 5, either Juan can make them and upload a new patch which one of us checks in, or someone with commit privileges can make the changes when checking in his current patch.

Jose: feel free to check in patches for Juan, just make sure to use the --user flag to the hg command to attribute them correctly, i.e.:

hg commit --user="(Juan's full name and email address)"

See for example the following changeset, where I did that when checking in his patch for bug 526788:

http://hg.mozilla.org/labs/personas/rev/657e0e151b10

Comment 7

[Jose E. Bolanos]

I'll take care of this one in a bit.

Comment 8

[Jose E. Bolanos]

The patch has been uploaded to the repository (with changes from comment 5):
http://hg.mozilla.org/labs/personas/rev/1e90c1a4d7ac