Closed
Bug 527387
Opened 15 years ago
Closed 15 years ago
Make parameter section sortkeys numeric and leave space between them
Categories
(Bugzilla :: Administration, task)
Bugzilla
Administration
Tracking
()
RESOLVED
FIXED
Bugzilla 3.6
People
(Reporter: mkanat, Assigned: mkanat)
References
Details
(Whiteboard: [es-ita])
Attachments
(1 file, 2 obsolete files)
8.81 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
Right now there's no space between the parameter section sortkeys, so you can't easily insert new modules in between them, in a hook or even during upstream development. Also, the sortkeys should be numeric instead of being strings. The attached simple patch accomplishes this goal.
Attachment #411112 -
Flags: review?(LpSolit)
Assignee | ||
Updated•15 years ago
|
Whiteboard: [es-ita]
Comment 1•15 years ago
|
||
Comment on attachment 411112 [details] [diff] [review] v1 >-$Bugzilla::Config::Attachment::sortkey = "025"; >+our $sortkey = 1600; Attachment is between the old 02 and 03 sortkeys, so it shouldn't be moved to 1600, but rather 350 with your numbering.
Attachment #411112 -
Flags: review?(LpSolit) → review-
Assignee | ||
Comment 2•15 years ago
|
||
Ah, thanks! :-)
Attachment #411112 -
Attachment is obsolete: true
Attachment #411218 -
Flags: review?(LpSolit)
Comment 3•15 years ago
|
||
Comment on attachment 411218 [details] [diff] [review] v2 >=== modified file 'Bugzilla/Config/Attachment.pm' >-$Bugzilla::Config::Attachment::sortkey = "025"; >+our $sortkey = 350; While you are renumbering these sortkeys, you could use a rounded number for this file and shift subsequent sortkeys. >=== modified file 'Bugzilla/Config/L10n.pm' This file doesn't exist.
Attachment #411218 -
Flags: review?(LpSolit) → review-
Assignee | ||
Comment 4•15 years ago
|
||
Fixed.
Attachment #411218 -
Attachment is obsolete: true
Attachment #412944 -
Flags: review?(LpSolit)
Comment 5•15 years ago
|
||
Comment on attachment 412944 [details] [diff] [review] v3 r=LpSolit
Attachment #412944 -
Flags: review?(LpSolit) → review+
Updated•15 years ago
|
Flags: approval+
Assignee | ||
Comment 6•15 years ago
|
||
Checking in Bugzilla/Config/Admin.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Admin.pm,v <-- Admin.pm new revision: 1.5; previous revision: 1.4 done Checking in Bugzilla/Config/Attachment.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Attachment.pm,v <-- Attachment.pm new revision: 1.9; previous revision: 1.8 done Checking in Bugzilla/Config/Auth.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Auth.pm,v <-- Auth.pm new revision: 1.5; previous revision: 1.4 done Checking in Bugzilla/Config/BugChange.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugChange.pm,v <-- BugChange.pm new revision: 1.8; previous revision: 1.7 done Checking in Bugzilla/Config/BugFields.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugFields.pm,v <-- BugFields.pm new revision: 1.8; previous revision: 1.7 done Checking in Bugzilla/Config/BugMove.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/BugMove.pm,v <-- BugMove.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Config/Core.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Core.pm,v <-- Core.pm new revision: 1.13; previous revision: 1.12 done Checking in Bugzilla/Config/DependencyGraph.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/DependencyGraph.pm,v <-- DependencyGraph.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Config/GroupSecurity.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/GroupSecurity.pm,v <-- GroupSecurity.pm new revision: 1.10; previous revision: 1.9 done Checking in Bugzilla/Config/LDAP.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/LDAP.pm,v <-- LDAP.pm new revision: 1.3; previous revision: 1.2 done Checking in Bugzilla/Config/MTA.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/MTA.pm,v <-- MTA.pm new revision: 1.18; previous revision: 1.17 done Checking in Bugzilla/Config/PatchViewer.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/PatchViewer.pm,v <-- PatchViewer.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Config/Query.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/Query.pm,v <-- Query.pm new revision: 1.8; previous revision: 1.7 done Checking in Bugzilla/Config/RADIUS.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/RADIUS.pm,v <-- RADIUS.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Config/ShadowDB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/ShadowDB.pm,v <-- ShadowDB.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/Config/UserMatch.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config/UserMatch.pm,v <-- UserMatch.pm new revision: 1.3; previous revision: 1.2 done Checking in template/en/default/admin/params/editparams.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/editparams.html.tmpl,v <-- editparams.html.tmpl new revision: 1.9; previous revision: 1.8 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•