Closed Bug 527575 Opened 15 years ago Closed 15 years ago

Comments appear to fail, but don't really.

Categories

(Webtools Graveyard :: BzAPI, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sdwilsh, Assigned: gerv)

Details

I have an issue where comments appear to fail (HTTP/400 response), but actually succeed. This is using the 2.0 version of the API. The response I get is: {"error":1,"xmlrpc_code":null,"message":"Empty response from server."}
Initial investigation: The "Empty response from server" message is coming back from the BZ::Client Perl module I'm using as the back end for the XML-RPC-based calls, of which adding a comment is one. So this could be a bug in that module, or one in the Bugzilla WebServices API. My tests in adding a comment to bugs on the staging server go fine - I can't reproduce the 400 error. (I'll test b.m.o. using this bug in a minute.) In the mean time, I've turned on additional logging for this module. Please can you reproduce the problem and then tell me the exact time you did it? :-) Gerv
This is a comment.
OK, I can reproduce on bugzilla.mozilla.org. Here's the story: in Bugzilla 3.2, the XML-RPC WebServices add_comment function, which the API is using on the backend, returns undef on success. This was changed in bug 473052 to return the comment ID, and that's what happens in 3.4. I will update the API to treat an undef return as success if the Bugzilla version is 3.2. <sigh> Gerv
This is a comment.
This is a comment.
Bingo. add_comment now returns a 201 Created response on bugzilla.mozilla.org. Thanks for the bug report! Gerv
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Version: 2.0 → 0.2
(In reply to comment #6) > Bingo. add_comment now returns a 201 Created response on bugzilla.mozilla.org. > Thanks for the bug report! My users will thank you too! Thanks!
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.