527966 - Update Yahoo! Favicon in default search plugins

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Kev Needham [:kev]]

Attachment: Updated (Purple) Yahoo! Search Plugin Icon

Yahoo! has changed their branding from the red Y! to a purple Y!, and has asked that we update Firefox to reflect this change where the red Y! is currently used (the search plugin; only other place I can think of is for mailto associations, but believe those are downloaded on the fly). 

I have attached the png, which should be used as the search plugin (fav)icon, instead of what is used today. This change should be applied to all locales except ja and ja-JP-mac (Yahoo! Japan is continuing to use the older branding at this time).

This change should be made for 3.6 and later.

Comment 1

[Kev Needham [:kev]]

Attachment: Updated en-US Yahoo! search plugin

Sample patch for the default en-US search plugin (browser/locales/en-US/searchplugins/yahoo.xml)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

There are a bunch of other Yahoos in http://mxr.mozilla.org/l10n-mozilla1.9.2/find?text=&kind=text&string=yahoo , changing them all might be a bit of a pain... Stas?

(The yahoo.xmls can be ignored, since they're overriden by the en-US one.)

Comment 3

[Kev Needham [:kev]]

I'm happy (well... willing, anyways) to provide patches for other locales, too.

Comment 4

[Staś Małolepszy :stas]

(In reply to comment #2)
> There are a bunch of other Yahoos in
> http://mxr.mozilla.org/l10n-mozilla1.9.2/find?text=&kind=text&string=yahoo ,
> changing them all might be a bit of a pain... Stas?

I can mass-land a change like this to all affected locales. I wrote a couple of scripts that make it easier the last time we needed to do something similar.

However, the timing is tricky right now. Localizers have already singed off on beta3 and we don't want to mess with the RC. If we mass-land a change now, we'd have to review all commits in all locales between the revision on which the localizers have signed off and the new revision of the mass-landing. And have the localizers test the new revision. Not good.

I discussed this with Axel and we'd prefer to land this for 3.6.1 for all locales. 

Also, is this changing in Fennec as well?

Comment 5

[Kev Needham [:kev]]

It's already changed in Fennec.

No major objections to landing this in 3.6.1, as I suspect 511017 will have to be the same.

Comment 6

[Staś Małolepszy :stas]

(In reply to comment #5)
> It's already changed in Fennec.

Ok, cool.

> No major objections to landing this in 3.6.1, as I suspect 511017 will have to
> be the same.

I think bug 511017 is different. We use one plugin file for google (en-US's google.xml) so if we land the patch from bug 511017, the new plugin will be included in all locales too. For yahoo, we actually use different plugin files, because yahoo doesn't do geo-detection on their side (AFAIK), so we have to go in and change every file separately.

Comment 7

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/9e3b7640f0b7

Comment 8

[Kev Needham [:kev]]

Hey folks, still need this in the default locale (en-US) for 3.6 (other locales are being tracked separately), please let me know if there's any issue with this. From what I understand, it's not landed yet.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 411747 [details] [diff] [review]
Updated en-US Yahoo! search plugin 

a192=beltzner

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/1fd273d0bfb6