527986 - new tabs open with partial thumbnail of old tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Madhava Enros [:madhava]]

When I open a new tab, it gets a weirdly scaled copy of the thumbnail of the tab I was on when I opened the new tab.

See here: http://www.flickr.com/photos/madhava_work/4096296146/

It should be blank.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This patch remove an unneeded call to updateThumbnail is the loaded page is about:blank by setting the background-color default of the tab as white.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Why change to specifying a border color identical to the background rather than using transparent?

I also don't really see the point of the border-radius change - doesn't make sense to specify it for a border that is invisible.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Huh, I have no idea how I managed to reset blocking-fennec...

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: screenshot with transparent borders

(In reply to comment #3)
> Why change to specifying a border color identical to the background rather than
> using transparent?

That's because otherwise the background-color is visible. (see attachement)

> I also don't really see the point of the border-radius change - doesn't make
> sense to specify it for a border that is invisible.

You're right, I don't see any good reasons to do that.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

Updated patch

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Fix the missing color for borders

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/8827852cdf72

Comment 9

[Aakash Desai [:aakashd]]

verified FIXED on builds:

Mozilla/5.0 (X11; U; Linux armv7l; Nokia N900; en-US; rv:1.9.2b4pre) Gecko/20091123 Firefox/3.6b4pre Fennec/1.0b6pre

and

Mozilla/5.0 (X11; U; Linux armv6l; Nokia N8xx; en-US; rv:1.9.3a1pre) Gecko/20091123 Firefox/3.7a1pre Fennec/1.0b5

Comment 10

[Aakash Desai [:aakashd]]

Litmus testcase https://litmus.mozilla.org/show_test.cgi?id=7095 has been updated to regression test this bug.