Closed
Bug 528076
Opened 16 years ago
Closed 16 years ago
Unsafe LIKE warning wrongly references mozIStorageConnection::escapeStringForLIKE
Categories
(Core :: SQLite and Embedded Database Bindings, defect)
Core
SQLite and Embedded Database Bindings
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: Unfocused, Assigned: Unfocused)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
In debug builds, when unsafely using LIKE, the following warning is given:
Unsafe use of LIKE detected! Please ensure that you are using mozIStorageConnection::escapeStringForLIKE and that you are binding that result to the statement to prevent SQL injection attacks.
The reference to mozIStorageConnection::escapeStringForLIKE is incorrect - that function is instead part of the mozIStorageStatement interface.
|
Assignee | |
Comment 1•16 years ago
|
||
|
||
Comment 2•16 years ago
|
||
Comment on attachment 411845 [details] [diff] [review]
Patch v1
r=sdwilsh
Attachment #411845 -
Flags: review?(sdwilsh) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 3•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
|
||
Updated•1 year ago
|
Product: Toolkit → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•