528122 - Reposition Archive menuitem next to Move and Copy menus

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[rsx11m]

The implementation of the archive function UI in bug 482458 followed (with a few exceptions) closely the Thunderbird example, including the placement of the "Archive" menuitem. However, as pointed out in the corresponding Thunderbird bug 525987, it appears somewhat misplaced between the New Message and Reply or Reply to All menuitems. Therefore the suggestion to reposition it closer to the Move and Copy items to which it is much more related. This also resolves any ambiguity what it is doing when put into the right context. While the patch for Thunderbird is still pending review, I'm filing an adaption for SeaMonkey here as this relocation obviously makes sense.

Comment 1

[rsx11m]

Attachment: Proposed patch

This patch puts the Archive menuitem in both the message's context menu and the main Message menu right above the Move submenu, thus establishing a context that Archive and Move are in fact related. I'm not adding another separator here, to avoid that there are too menu of those in the Message menu with just a few items in each block.

Comment 2

[[e-mail]]

Comment on attachment 411875 [details] [diff] [review]
Proposed patch

Might want to move the corresponding entries in the DTD for consistency?

Comment 3

[rsx11m]

Attachment: Proposed patch (v2)

Updated patch with related messenger.dtd entries moved per Neil's suggestion.

Comment 4

[Karsten Düsterloh]

Comment on attachment 412518 [details] [diff] [review]
Proposed patch (v2)

Sorry for the delay.

Comment 5

[rsx11m]

No problem, thanks for the reviews.

Push for comm-central please. I assume this won't qualify for 2.0.1 due to rearranging the identifiers, even with the changes in the DTD file omitted?

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/7a9f8a2a207c

Comment 7

[rsx11m]

Thanks! Answering my own question in comment #5 - given that the change of
order in identifiers may potentially trip an extension overlaying that menu,
it's probably not a good idea to have this on the 1.9.1 branch. Thus, I'm not going to request 2.0.1 approval for the patch or its DTD-less counterpart.