Last Comment Bug 528122 - Reposition Archive menuitem next to Move and Copy menus
: Reposition Archive menuitem next to Move and Copy menus
Product: SeaMonkey
Classification: Client Software
Component: MailNews: General (show other bugs)
: Trunk
: All All
-- trivial (vote)
: seamonkey2.1a1
Assigned To: rsx11m
Depends on:
  Show dependency treegraph
Reported: 2009-11-11 19:33 PST by rsx11m
Modified: 2009-11-30 17:43 PST (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Proposed patch (4.19 KB, patch)
2009-11-11 19:35 PST, rsx11m
neil: superreview+
Details | Diff | Splinter Review
Proposed patch (v2) (7.50 KB, patch)
2009-11-15 17:50 PST, rsx11m
mnyromyr: review+ superreview+
Details | Diff | Splinter Review

Description User image rsx11m 2009-11-11 19:33:34 PST
The implementation of the archive function UI in bug 482458 followed (with a few exceptions) closely the Thunderbird example, including the placement of the "Archive" menuitem. However, as pointed out in the corresponding Thunderbird bug 525987, it appears somewhat misplaced between the New Message and Reply or Reply to All menuitems. Therefore the suggestion to reposition it closer to the Move and Copy items to which it is much more related. This also resolves any ambiguity what it is doing when put into the right context. While the patch for Thunderbird is still pending review, I'm filing an adaption for SeaMonkey here as this relocation obviously makes sense.
Comment 1 User image rsx11m 2009-11-11 19:35:57 PST
Created attachment 411875 [details] [diff] [review]
Proposed patch

This patch puts the Archive menuitem in both the message's context menu and the main Message menu right above the Move submenu, thus establishing a context that Archive and Move are in fact related. I'm not adding another separator here, to avoid that there are too menu of those in the Message menu with just a few items in each block.
Comment 2 User image 2009-11-15 16:08:15 PST
Comment on attachment 411875 [details] [diff] [review]
Proposed patch

Might want to move the corresponding entries in the DTD for consistency?
Comment 3 User image rsx11m 2009-11-15 17:50:42 PST
Created attachment 412518 [details] [diff] [review]
Proposed patch (v2)

Updated patch with related messenger.dtd entries moved per Neil's suggestion.
Comment 4 User image Karsten Düsterloh 2009-11-28 11:40:57 PST
Comment on attachment 412518 [details] [diff] [review]
Proposed patch (v2)

Sorry for the delay.
Comment 5 User image rsx11m 2009-11-28 11:45:26 PST
No problem, thanks for the reviews.

Push for comm-central please. I assume this won't qualify for 2.0.1 due to rearranging the identifiers, even with the changes in the DTD file omitted?
Comment 6 User image Stefan [:stefanh] 2009-11-29 10:07:20 PST
Comment 7 User image rsx11m 2009-11-30 17:43:04 PST
Thanks! Answering my own question in comment #5 - given that the change of
order in identifiers may potentially trip an extension overlaying that menu,
it's probably not a good idea to have this on the 1.9.1 branch. Thus, I'm not going to request 2.0.1 approval for the patch or its DTD-less counterpart.

Note You need to log in before you can comment on or make changes to this bug.