52819 - askSendFormat dialog popup all the time even when the body doesn't contain any formating

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[Jean-Francois Ducarroz]

I cannot send anymore a message whitout be asking to convert my message to plain text. It's a news regression!

Steps:
------
1) open a new message compose
2) address the message to yourself and to "[e-mail]"
3) enter a subject
4) type "Hello" in the subject
5) send the message

The AskSendFormat dialog popup. It sould not!

Comment 1

[Jean-Francois Ducarroz]

it's a dogfood stopper for me. I have the fix for it

Comment 2

[Jean-Francois Ducarroz]

here is the fix:

Index: MsgComposeCommands.js
===================================================================
RCS file: /cvsroot/mozilla/mailnews/compose/resources/content/MsgComposeCommands.js,v
retrieving revision 1.126
diff -b -u -2 -r1.126 MsgComposeCommands.js
--- MsgComposeCommands.js	2000/09/14 04:55:12	1.126
+++ MsgComposeCommands.js	2000/09/15 18:42:30
@@ -1524,5 +1524,5 @@
     try {
         return msgCompose.bodyConvertible(
-             window.editorShell.contentWindow.document.childNodes[1]);
+             window.editorShell.contentWindow.document.childNodes[0]);
     } catch(ex) {}
     return msgCompConvertible.No;

Comment 3

[Ben Bucksch (:BenB)]

Yes, it's a regression, but dunno what caused it. workedforme until yesterday or so.
Can't give r= :-(, because I don't know, what nodes it accessed and now
accesses, but your patch fixes the bug for me, if that helps.

Comment 4

[esther]

Note: With today's builds 2000-09-15 on win98, mac and linux if you change the
pref back to "Send Message in both HTML and plain text" you don't get the pop up
when you send.  Is this the same for you ducarroz?  If so, this bug is about the
default setting being wrong?

Comment 5

[esther]

Sorry, I when I tested it I didn't change the addressing to newsgroup when
entering [e-mail], so mine went through OK.  When I do change the addressing
field to Newsgroup I'm seeing this all the time.

Comment 6

[Jean-Francois Ducarroz]

It's about when the pref is set to "Ask Me". We should not ask the user if the message body doesn't contains any HTML 
formatting. In this case, we just send the message in plain text.

Comment 7

[Jean-Francois Ducarroz]

sorry, I was trying to say:
...In this case, we should just send the message in plain text without asking him.

Comment 8

[Peter Trudelle]

PDT agrees: P2

Comment 9

[Jean-Francois Ducarroz]

*** Bug 52881 has been marked as a duplicate of this bug. ***

Comment 10

[Jean-Francois Ducarroz]

*** Bug 53040 has been marked as a duplicate of this bug. ***

Comment 11

[Jim Roskind]

This won't stop dogfood use, so marking dogfood-minus.
This is a pain, and it is nice to see that the fix-in-hand will probably get 
landed in the P2 landing window ;-).

Comment 12

[Jean-Francois Ducarroz]

Fixed and checked in.

Instead of "guessing" which document child is the message body, I use now the 
editor function GetRootElement().

Comment 13

[fenella]

Linux (2000-09-19-08 M18)
Win32 (2000-09-19-09 M18)
MAc (2000-09-19-09 M18)
I re-test this using the original scenario and changing the addressing
field to Newsgroup I do not see this problem.