528271 - collect new data sent by CrashReporter: "ReleaseChannel"

Status: RESOLVED WORKSFORME

(Socorro :: General, task)

Description

[David Dahl :ddahl]

The crash reporter will now be sending "ReleaseChannel", which needs to be collected, etc. see bug 526623

Comment 1

[Samuel Sidler (old account; do not CC)]

morgamic: I think 1.1 is going out today, but I'd like this in 1.2 if possible. Should be easy enough to collect. There's a follow up bug to process 100% of reports that are on specific channels (like "beta").

Comment 2

[K Lars Lohn [:lars] [:klohn]]

so how is this data coming in?  Through the POST like the other data?  Which versions are sending it?  I'm not finding any json/dump pairs with this data in the raw dumps repository.

Comment 3

[Samuel Sidler (old account; do not CC)]

I can answer the last question. It'll only come in with Firefox 3.6 versions, not with Firefox 3.5 or 3.0 versions.

Comment 4

[K Lars Lohn [:lars] [:klohn]]

even looking at crashes from 3.6 betas, I'm not seeing "ReleaseChannel" come in on the POST.  Exactly what version was the first to include this value?

Comment 5

[Samuel Sidler (old account; do not CC)]

Hm. Looking at bug 526623, apparently this hasn't landed on 1.9.2 yet. You will only see this with 3.7a1pre builds.

Comment 6

[K Lars Lohn [:lars] [:klohn]]

double hmm, I'm not seeing in crashes identifying themselves as "3.7a1pre" either.  Does that mean that is coming in by some other "out of band" method other than http POST data?  Is it embedded in the URI that is used to do the post?

Comment 7

[David Dahl :ddahl]

We annotate the crashreporter onstartup with ReleaseChannel = the preference "app.update.channel".

I was assured by reviewers of the patch that was all I had to do. My testing methodology was to install ted's CrashMe extension, turn on the CrashRporter in the application.ini, unplug the ethernet and turn off wireless, and crash the browser. In ~/.mozilla/firefox/CrashReports/pending the latest report data definately had the ReleaseChannel information in it.

I'm pretty sure I traced all of this with gdb as well.  Can you varify that the ReleaseChannel info is in your crashreport locally?

Comment 8

[(not currently active) Ted Mielczarek]

(In reply to comment #6)
> double hmm, I'm not seeing in crashes identifying themselves as "3.7a1pre"
> either.  Does that mean that is coming in by some other "out of band" method
> other than http POST data?  Is it embedded in the URI that is used to do the
> post?

No, all the data comes in the POST data. You can try using the crashme extension with a trunk build (3.7a1pre) to verify that the data gets submitted.

Comment 9

[K Lars Lohn [:lars] [:klohn]]

so really there is nothing to be done here.  Collector automatically rolls the POST variables into the json.  It is my understanding that this data is only to be used to assist in throttling.  For throttling, it doesn't need to be put in the database.  If this is not correct, then I need to be notified.

We do, however really need to verify that it is actually being sent.  I'm not seeing it even in the submissions from FF3.7a1pre

Comment 10

[K Lars Lohn [:lars] [:klohn]]

reopen if there is something to do...

Comment 11

[Samuel Sidler (old account; do not CC)]

Lars: I guess I'd say that this bug should morph to be...

  1) Ensure we actually send this data properly, in a way Socorro can use it.
  2) Implement server-side non-throttling for specific channels ("beta").

Or do you want new bugs on that?

Comment 12

[(not currently active) Ted Mielczarek]

Using crash me now in a trunk nightly, and clicking "details" in the crash reporter, I can see "ReleaseChannel=nightly" among the data to be sent, so it's being sent correctly client-side.