Closed
Bug 528320
Opened 16 years ago
Closed 16 years ago
Improve warning-handling on windows
Categories
(Core Graveyard :: Nanojit, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: graydon, Assigned: graydon)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(1 file)
|
13.95 KB,
patch
|
rreitmai
:
review+
|
Details | Diff | Splinter Review |
This patch tightens the nanojit-central build infrastructure to behave, warnings-wise, much more like tamarin on windows: -W4 warning sensitivity, -WX (warnings-are-errors mode), and a number of explicit inhibitions for the exceptions. This should prevent most of the breaks-a-windows-tamarin-build bugs we've recently let through.
Everything else in the patch is just compensation for these changes, mostly cleaning up things that weren't warning-safe or changing configury to adapt.
Attachment #412063 -
Flags: review?(rreitmai)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 412063 [details] [diff] [review]
tighten the conditions
ty
Attachment #412063 -
Flags: review?(rreitmai) → review+
|
|
||
Comment 2•16 years ago
|
||
Nanojit fix was pushed by Graydon:
http://hg.mozilla.org/projects/nanojit-central/rev/c1dd9d0db4cf
Tracemonkey:
http://hg.mozilla.org/tracemonkey/rev/8f9b6c410fd0
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
|
||
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•