Drop NS_COMPOSITION_QUERY event

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Widget
RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla1.9.3a1
inputmethod
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 412150 [details] [diff] [review]
Patch v1.0

Now, we don't use NS_COMPOSITION_QUERY event because the works are stolen by the query content events and they are better.

We can remove NS_COMPOSITION_QUERY event and the related handles (nsIDOMCompositionListener::HandleQueryComposition and nsIEditorIMESupport::queryComposition, they are not scriptable).

I think nsTextEventReply will be dropped completely, however, it needs to change GTK2 widget code. So, I think it should be done after bug 520732. Therefore, unfortunately, this patch cannot drop nsEditor::QueryComposition, it's also needed for the nsEditor::BeginComposition.
Attachment #412150 - Flags: review?(roc)
I only removed the OS/2's code because OS/2 doesn't support IME on trunk.

Maybe, we cannot build on BeOS but we are still managing in our tree, therefore, I just commented out the code for BeOS's maintainers in the future.
Created attachment 412151 [details] [diff] [review]
Patch v1.0.1

Oops, sorry for the spam, I posted older patch.
Attachment #412150 - Attachment is obsolete: true
Attachment #412151 - Flags: review?(roc)
Attachment #412150 - Flags: review?(roc)
Attachment #412151 - Flags: superreview?(neil)

Updated

9 years ago
Attachment #412151 - Flags: superreview?(neil) → superreview+
http://hg.mozilla.org/mozilla-central/rev/45b482e31486
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Keywords: inputmethod
Blocks: 79135
You need to log in before you can comment on or make changes to this bug.