Closed
Bug 528435
Opened 15 years ago
Closed 15 years ago
Drop NS_COMPOSITION_QUERY event
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod)
Attachments
(1 file, 1 obsolete file)
16.30 KB,
patch
|
roc
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Now, we don't use NS_COMPOSITION_QUERY event because the works are stolen by the query content events and they are better. We can remove NS_COMPOSITION_QUERY event and the related handles (nsIDOMCompositionListener::HandleQueryComposition and nsIEditorIMESupport::queryComposition, they are not scriptable). I think nsTextEventReply will be dropped completely, however, it needs to change GTK2 widget code. So, I think it should be done after bug 520732. Therefore, unfortunately, this patch cannot drop nsEditor::QueryComposition, it's also needed for the nsEditor::BeginComposition.
Attachment #412150 -
Flags: review?(roc)
Assignee | ||
Comment 1•15 years ago
|
||
I only removed the OS/2's code because OS/2 doesn't support IME on trunk. Maybe, we cannot build on BeOS but we are still managing in our tree, therefore, I just commented out the code for BeOS's maintainers in the future.
Assignee | ||
Comment 2•15 years ago
|
||
Oops, sorry for the spam, I posted older patch.
Attachment #412150 -
Attachment is obsolete: true
Attachment #412151 -
Flags: review?(roc)
Attachment #412150 -
Flags: review?(roc)
Attachment #412151 -
Flags: review?(roc) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #412151 -
Flags: superreview?(neil)
Updated•15 years ago
|
Attachment #412151 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/45b482e31486
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
Assignee | ||
Updated•14 years ago
|
Keywords: inputmethod
You need to log in
before you can comment on or make changes to this bug.
Description
•