Closed
Bug 528442
Opened 15 years ago
Closed 15 years ago
[HTML5][Patch] Call WillCallDoneAddingChildren for SVG scripts
Categories
(Core :: DOM: HTML Parser, defect, P1)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
People
(Reporter: hsivonen, Assigned: hsivonen)
Details
Attachments
(1 file, 1 obsolete file)
|
958 bytes,
patch
|
mozilla+ben
:
review+
|
Details | Diff | Splinter Review |
The tree op executor should call WillCallDoneAddingChildren on newly-created SVG script elements to mark them as parser-created, since the usual "from parser" flag has no effect on the SVG script creator function.
|
Assignee | |
Comment 1•15 years ago
|
||
No test case, because I was unable to develop a test case that'd fail without this patch but succeed with the patch. However, I believe this patch is necessary, because by inspection the code is wrong without this patch (compare with the XML content sink).
|
|
Assignee | |
Comment 2•15 years ago
|
||
Oops. Sorry. I forgot to clean up the makefile entry for the test case that wasn't a real test case.
Attachment #412190 -
Attachment is obsolete: true
Attachment #412191 -
Flags: review?(bnewman)
Attachment #412190 -
Flags: review?(bnewman)
|
||
Updated•15 years ago
|
Attachment #412191 -
Flags: review?(bnewman) → review+
|
|
Assignee | |
Updated•15 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•15 years ago
|
Summary: [HTML5] Call WillCallDoneAddingChildren for SVG scripts → [HTML5][Patch] Call WillCallDoneAddingChildren for SVG scripts
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/59851886d377
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•