528539 - Start over should warn about incorrect username/password before prompting for secret phrase

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ragavan S [:rags]]

When you start over, if you enter a wrong username/password combination, you still get prompted to enter your passphrase. After you enter your passphrase, you get dumped back in the first screen with an error message saying incorrect user name or password.

If you enter a wrong username/password, then inform the user right away before proceeding to the passphrase screen.

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/944f0b6acac0
Show Connecting... when signin in on page 0 and Verifying... when checking the passphrase on page 1.

Comment 2

[Daniel Holbert [:dholbert] (PTO until 2/24)]

This bug's change:
> +++ b/source/chrome/content/sync.js
>   onLoginError: function WeaveWin_onLoginError() {
+    // Don't notify on missing passphrase errors
+    if (!Weave.Service.passphrase)
+      return;

caused the regression bug 530697.

It looks like this chunk intends to make things easier on the user, but it actually causes an annoying re-prompt for master password (if password db is still locked -- e.g. if user clicked 'connect' and then cancels master password dialog)