Storage stream's output stream should report itself as blocking

RESOLVED FIXED in mozilla11

Status

()

Core
XPCOM
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: mayhemer, Assigned: bjarne)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Its implementation behaves that way, it never throws WOULD_BLOCK error, when the buffer is full (we are on the limit) we end up with NS_ERROR_OUT_OF_MEMORY (what is also not really correct).

The main reason is to be able to use storage stream with nsInputStreamTee that expects the sink stream be blocking and be able to limit the written size, what otherwise storage stream really fits.

See bug 515051 comment 63 and further.
(Assignee)

Comment 1

5 years ago
Created attachment 574448 [details] [diff] [review]
SImple fix

This might be needed for a patch for bug #602611...
Attachment #574448 - Flags: review?(bzbarsky)
Comment on attachment 574448 [details] [diff] [review]
SImple fix

Seems fine to me, but please double-check with biesi?
Attachment #574448 - Flags: review?(bzbarsky) → review?(cbiesinger)
Comment on attachment 574448 [details] [diff] [review]
SImple fix

this is probably OK, I don't think we ever use it with a stream copier or somesuch (if we did, we should reconsider this change)
Attachment #574448 - Flags: review?(cbiesinger) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Assignee: nobody → bjarne

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/031b48dfef03
Keywords: checkin-needed
Target Milestone: --- → mozilla11

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/031b48dfef03
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.