Closed
Bug 528569
Opened 15 years ago
Closed 13 years ago
Storage stream's output stream should report itself as blocking
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mayhemer, Assigned: bjarne)
Details
Attachments
(1 file)
|
648 bytes,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
Its implementation behaves that way, it never throws WOULD_BLOCK error, when the buffer is full (we are on the limit) we end up with NS_ERROR_OUT_OF_MEMORY (what is also not really correct). The main reason is to be able to use storage stream with nsInputStreamTee that expects the sink stream be blocking and be able to limit the written size, what otherwise storage stream really fits. See bug 515051 comment 63 and further.
|
Assignee | |
Comment 1•13 years ago
|
||
This might be needed for a patch for bug #602611...
Attachment #574448 -
Flags: review?(bzbarsky)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 574448 [details] [diff] [review] SImple fix Seems fine to me, but please double-check with biesi?
Attachment #574448 -
Flags: review?(bzbarsky) → review?(cbiesinger)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 574448 [details] [diff] [review] SImple fix this is probably OK, I don't think we ever use it with a stream copier or somesuch (if we did, we should reconsider this change)
Attachment #574448 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Updated•13 years ago
|
Assignee: nobody → bjarne
|
|
||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/031b48dfef03
Keywords: checkin-needed
Target Milestone: --- → mozilla11
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/031b48dfef03
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•