528578 - Socorro UI - stack frame improperly identified as the crashing thread.

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[K Lars Lohn [:lars] [:klohn]]

in crash http://crash-stats.mozilla.com/report/index/3539ce85-8b7c-4585-91dd-d30642091113 no thread was identified as the cause of the crash.  In fact, that is verified by looking at the empty 4th field of the "Crash" line of the "Raw Crash" information.  Yet the UI has listed stack frame 0 and labeled it as "Crashing Thread".

Even just relabeling it to "Thread 0" implies that we know something more about that thread than we really do. 

I think it should show no stack frame at all in this case.  It should still offer a "show/hide threads" link which would reveal all threads.

Comment 1

[Laura Thomson :laura]

This seems small to fix and important because it's misleading.  Tentatively scheduling for 1.8

Comment 2

[Laura Thomson :laura]

2.x

Comment 3

[Schalk Neethling [:espressive]]

In order to work on this bug I need to trigger the same behavior as described in the initial comment. Currently I cannot find a crash that exhibit the same behavior.

[:lars] Can you suggest a way that one could derive a test case for this bug which I can test against?

Comment 4

[K Lars Lohn [:lars] [:klohn]]

the following crashes exhibit this problem:

 ea4b97e1-75bf-4d81-b412-0a6e52120227
 b86da106-9ccc-4bc3-8e73-96acf2120227
 22a76af5-df53-49ff-a0b8-fe7f42120227
 c53d8936-0f4d-4208-ac99-b2e012120227
 9ac98df9-b64e-468b-91d1-51c312120227
 f815a7bd-e083-4f52-bec4-d73a32120227
 e5c3af13-42a3-4384-a9cc-94d242120227
 61724f5e-a997-4742-aa87-7f6882120227
 31c7e13e-8d02-40de-8998-c09422120227
 78ce5959-4301-4574-a099-289412120227
 075b37b6-eda8-446a-85d5-419e52120227
 8bcc5ef0-771c-4102-9dac-850942120227
 afcccd50-e36f-427e-a137-4b99d2120227
 01bea168-0a80-47c4-9c68-40eac2120227
 dbdab082-c90a-4f8a-a863-f21d52120227
 f24ca4bb-e3cc-4ce9-81ed-9f57b2120227
 267418a3-188e-4530-a332-9871d2120227
 9b2270c8-9ef4-4767-b344-5eefd2120227
 ac21c43a-aabd-4ec3-a22b-5329a2120227
 18592720-db38-4247-adb3-022632120227

Comment 5

[Schalk Neethling [:espressive]]

Sent pull request :: https://github.com/mozilla/socorro/pull/391

TEST CASE
----------

The following reports has no crashing thread and thus there should not be one identified via the UI

https://espressive-dev.allizom.org/report/index/b86da106-9ccc-4bc3-8e73-96acf2120227 :: NO CRASHING THREAD
https://espressive-dev.allizom.org/report/index/ea4b97e1-75bf-4d81-b412-0a6e52120227 :: NO CRASHING THREAD
https://espressive-dev.allizom.org/report/index/22a76af5-df53-49ff-a0b8-fe7f42120227 :: NO CRASHING THREAD

The following reports has a crashing thread and thus there should be one identified via the UI

https://espressive-dev.allizom.org/report/index/ec1b22eb-36b7-4915-82ab-612f32120218 :: HAS CRASHING THREAD

The following report has no raw dump and thus there should be no identified thread nor any other threads via the UI

https://espressive-dev.allizom.org/report/index/5ecafb57-9384-4142-bb3c-038102120218 :: NO RAW DUMP

The report UUIDs above all load from production

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

I would add a note when there is no known crashing thread saying so, so the "See other crashing threads" link makes a bit more sense. If I'm a user and I'm used to seeing a crashing thread there, I'll be a bit confused not to see any and potentially think it's a bug.

Comment 7

[Schalk Neethling [:espressive]]

[:adrian] Completely agree, updating pull request.

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6becac62a792eea642a126bc8968eab8db95f7e2
setting crashed_thread to -1 if there was no identified crashing thread fixes bug 528578

https://github.com/mozilla/socorro/commit/52f4b82a7e92574a52ebf3073e81efbbe0f5c24c
Merge pull request #412 from ossreleasefeed/bug528578-improperly-identified-crashing-thread

setting crashed_thread to -1 if there was no identified crashing thread fixes bug 528578

Comment 9

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage using the the signature list that :lars identified in comment 4.

When no thread was identified as the cause of the crash the an error message is appended to the processor notes.