528676 - e-mail list not updated when using next/prev button in Create New Calendar wizard

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.1.6pre) Gecko/20091111 Lightning/1.0pre Shredder/3.0pre

"Create New Calendar" wizard, tab "Customize your calendar". Each time next/prev button is used, E-Mail dropdown list is updated with email by adding email but without cleaning list previously.

Reproducible: Always

Steps to Reproduce:
1. Open wizard for creating new calendar
2. Select local calendar (the same for remote)
3. Press next button
4. Press prev button
5. Repeat step 3 and 4 a few times.
Actual Results:  
Drop-down list E-mail contains many the same emails (in my case "None" because no email account has been added to TH)

Expected Results:  
List should be cleared before adding new email so it won't contain duplicates

see screenshot

Comment 1

[Damian Szczepanik]

Attachment: screenshot

Comment 2

[Decathlon]

Attachment: fix

As suggested by Damian Szczepanik, this patch clears the list before adding new elements.

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 416560 [details] [diff] [review]
fix

r=mschroeder, but please add a comment explaining why we need to do this.

Comment 4

[Decathlon]

Attachment: fix with comment

Added comment to the patch.

Comment 5

[Martin Schröder [:mschroeder]]

http://hg.mozilla.org/releases/comm-1.9.1/rev/f445c4260b37
http://hg.mozilla.org/comm-central/rev/8d71436563b5

Comment 6

[Martin Schröder [:mschroeder]]

Comment on attachment 416565 [details] [diff] [review]
fix with comment

Checked in with modified comments.

Comment 7

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".