The default bug view has changed. See this FAQ.

[Mac Classic] History drop-down height doesn't match full number of rows

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
Themes
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

({fixed-seamonkey2.0.5})

Trunk
seamonkey2.1a1
x86
Mac OS X
fixed-seamonkey2.0.5

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

585 bytes, patch
neil@parkwaycc.co.uk
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
The 25em height of the history drop-down makes room for about 16 rows in Mac Classic. The "about" is the problem here - when you move down to the last visible entry, the list will scroll down a couple of pixels since the height doesn't match a full number of rows.

25em equals to 16 rows + a few pixels. Now, every row is 19px high, so optionally we should have a max-height of 304px
(Assignee)

Comment 1

8 years ago
Created attachment 412433 [details] [diff] [review]
Fix height

Modern actually only show 15 rows, and there's also some extra space at the bottom, so all rows fit.
Attachment #412433 - Flags: superreview?(neil)
Attachment #412433 - Flags: review?(mnyromyr)
(Assignee)

Comment 2

8 years ago
Karsten, this is also a comm-1.9.1 problem, so you should be able to look at it ;-)
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.1a1

Comment 3

8 years ago
Comment on attachment 412433 [details] [diff] [review]
Fix height

How can you be sure that rows will always be 19px?
Attachment #412433 - Attachment is patch: true
Attachment #412433 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 4

8 years ago
(In reply to comment #3)
> (From update of attachment 412433 [details] [diff] [review])
> How can you be sure that rows will always be 19px?

The min-height of a menuitem is 19px and the font we use here is smaller than in regular menuitems and you can't change the font-size in the OS ui.
(Assignee)

Comment 5

8 years ago
fwiw, seems that 25.3em will also give me the height I want.

Comment 6

8 years ago
Based on your figures we have 1em = 12px, so if you use 24em you should get 15 rows of 19 pixels plus 3 spare pixels, which will look similar to Modern (where we use 25em to get 16 rows of 17 pixels plus 3 spare pixels). If you don't have a border you could use 27em which would get you 17 rows plus 1 spare pixel.

Comment 7

7 years ago
Given that Modern on Mac has 15 rows + some pixels, I'd prefer the 24em for Classic.
(Assignee)

Comment 8

7 years ago
Using em will just get it "almost" right.

Comment 9

7 years ago
Granted, but 15 rows à 19px would be 285px...
In either case, the number of rows should be the same for both themes, so I'm a bit unsure why this bug only covers Classic? One could argue that the Classic dropdown is more than sufficient to show its 15 entries like Modern does...
(Assignee)

Comment 10

7 years ago
Sure, we can have 285px, I'm more concerned with not having any empty space at the bottom ;-)

Updated

7 years ago
Attachment #412433 - Flags: review?(mnyromyr) → review+

Comment 11

7 years ago
Comment on attachment 412433 [details] [diff] [review]
Fix height

Okay, given you make that 285px so that Classic and Modern show the same number of lines.
(Assignee)

Comment 12

7 years ago
Created attachment 436883 [details] [diff] [review]
make it 285px

Actually, we may want to have a different approach for trunk (since we don't support tiger, we can restyle it a bit), but I would like this to land on branch.
Attachment #412433 - Attachment is obsolete: true
Attachment #436883 - Flags: superreview?(neil)
Attachment #412433 - Flags: superreview?(neil)
Comment on attachment 436883 [details] [diff] [review]
make it 285px

This would be wrong on any sane OS, but fortunately this is a Mac-only file.
Attachment #436883 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 14

7 years ago
Comment on attachment 436883 [details] [diff] [review]
make it 285px

This is a safe ui-tweak for mac that will correct an annoyance in the history drop-down list.
Attachment #436883 - Flags: approval-seamonkey2.0.5?

Updated

7 years ago
Attachment #436883 - Flags: approval-seamonkey2.0.5? → approval-seamonkey2.0.5+
(Assignee)

Comment 15

7 years ago
http://hg.mozilla.org/comm-central/rev/2472e56b6660
http://hg.mozilla.org/releases/comm-1.9.1/rev/3ee2884da94f
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: fixed-seamonkey2.0.5
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.