528866 - Unnecessary redo menu is enabled when cancel properties dialog of bookmark.

Status: RESOLVED INCOMPLETE

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.2b3pre) Gecko/20091115 Firefox/3.5.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20091115 Minefield/3.7a1pre ID:20091115042134

Unnecessary redo menu is enabled when cancel properties dialog of bookmark.

I change nothing and canceled it, and it is not rational that "Redo" becomes enabled.

Reproducible: Always

Steps to Reproduce:
1.Start Minefield with new profile
2.Open Library (Ctrl+Shift+B)
3.Right-click on "Getting Started" in the Bookmarks Toolbar
4.Select Properties in the context menu.
5.Click "Cancel" button in the Properties dialog
6.Open "Organize" menu in the Library
Actual Results:  
"Redo" menu is enabled

Expected Results:  
Should not change undo/redo state when click "Cancel" in the properties dialog

Comment 1

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 3.6.13 or later in safe mode? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

You can also try to reproduce in Firefox 4 Beta 8 or later, there are many improvements in the new version, http://www.mozilla.com/en-US/firefox/all-beta.html

Comment 2

[Alice0775 White]

Able to reproduce on   Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101231 Firefox/4.0b9pre

Comment 3

[Tyler Downer [He/Him]]

Alice, do you not have CANCONFIRM privs?

Comment 4

[Alice0775 White]

yes, i have,

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

By a quick Check, this is a Regression introduced in Gecko 1.9.1/Firefox 3.5.

Comment 6

[Alice0775 White]

Regression window:
Works;
http://hg.mozilla.org/mozilla-central/rev/90ddcaa921e4
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b2pre) Gecko/20081030 Minefield/3.1b2pre
Fails:
http://hg.mozilla.org/mozilla-central/rev/a131999fa900
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b2pre) Gecko/20081031 Minefield/3.1b2pre
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=90ddcaa921e4&tochange=a131999fa900

Inlocal build:
build from 46a0fed0b3df : fails
build from 6fd85628b1dc : fails
build from 307153dd899d : works

Candidate changeset of the regression:
6fd85628b1dc	Marco Bonardo — Bug 411261 - Bookmark properties dialog needs tagging UI, r=dietrich, ui-r:changes required by Faaborg in bug 459958

Comment 7

[(mostly gone) XtC4UaLL [:xtc4uall]]

Thanks a Ton, Alice!