52888 - classic skin: scrollbar should be at right edge of window

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P4)

Description

[Jesse Ruderman]

I like the way Modern (minus bug 52887) and Blue put the scrollbar at the far 
edge of the window.  This makes the edge of the scrollbar the same as the edge 
of the screen when the window is maximized under Windows 98, so it is easier to 
grab the scrollbar with the mouse.  I'd like to see this behavior extended to 
the classic skin.

Comment 1

[hangas]

Sending to Joe for investigation.

Comment 2

[Joe Hewitt (gone)]

I am marking this WONTFIX because the scrollbar's alignment is precisely what 
it should be to emulate the correct "classic" look.  Compare to IE scrollbars 
and you'll see they are identical.

Comment 3

[Jesse Ruderman]

I don't see why Mozilla shouldn't try to be better than IE or NS4.x here.

Comment 4

[Patty Mac]

marking verified (2000-10-16-09-MN6).

Comment 5

[Jerry Baker]

*** Bug 54800 has been marked as a duplicate of this bug. ***

Comment 6

[Matthew T (active 1999-2002)]

Someone want to attach a screenshot? This seems like an obvious usability win.

Comment 7

[Joe Hewitt (gone)]

While I sympathize with the usability aspect of this, I'll state again that the
goal of the classic skin is to emulate the exact look of the platform. 
Deviating from that look only leads to quirks in the UI that people don't
expect.  In Windows, scrollbars don't touch the right edge of the window,
period.  I think it should stay this way.

Comment 8

[Matthew T (active 1999-2002)]

Reopening after discussion with Hewitt in IRC. Windows apps are not consistent 
in this regard: while Internet Explorer and MS Publisher have the scrollbar two 
pixels away from the edge of the screen, MS Excel has it one pixel away, and MS 
Publisher, mIRC, and MS Photo Editor have the scrollbar touching the edge of 
the screen. Since there doesn't seem to be a standard, we may as well choose 
the option (touching the edge) which makes the target area a hundred times 
larger than the other options.

Comment 9

[Matthew T (active 1999-2002)]

Sorry, by `Internet Explorer and MS Publisher' I meant `Internet Explorer and 
MS Word'.

Comment 10

[Jesse Ruderman]

This also applies to the left edge of the window, for choosing a sidebar panel 
(if the sidebar is open) or for starting a selection from the left edge of the 
screen (if the sidebar is off).

Opening a collapsed sidebar already works fine, which surprises me.

Comment 11

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 12

[shliang]

*** Bug 96012 has been marked as a duplicate of this bug. ***

Comment 13

[sairuh (rarely reading bugmail)]

a problem on win and linux.

Comment 14

[shliang]

Attachment: patch

Comment 15

[Joe Hewitt (gone)]

Comment on attachment 52105 [details] [diff] [review]
patch

You shouldn't be removing the borders on the toolbox and the statusbar, but the rest of the patch looks correct.

Comment 16

[shliang]

Attachment: doing this over

Comment 17

[shliang]

Attachment: doing this over

Comment 18

[jag (Peter Annema)]

Comment on attachment 55356 [details] [diff] [review]
doing this over

r=jag

I like this!

But make sure Joe agrees with removing the other borders.

Comment 19

[Joe Hewitt (gone)]

Comment on attachment 55356 [details] [diff] [review]
doing this over

sr=hewitt

Comment 20

[shliang]

checked in

Comment 21

[Patty Mac]

Verified the patch.

Comment 22

[Jesse Ruderman]

See also bug 112885, "Scroll bar in message pane shouldn't have border-right".

Comment 23

[Wenqing Jiang]

The original design is good, and the 'fix' simply uglify the vertical
scroll bar - the right border is not symitry with the left border,
and the vertical scrollbar looks higher (in Z axis) than the window
frame. (see also bug #177104).

I agree with comment #7.  Should I open a new bug?