crash [@ _pushpopupsenabledstate() ]

RESOLVED FIXED in mozilla1.9.3a2

Status

()

Core
Plug-ins
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Martin Stránský, Assigned: Martin Stránský)

Tracking

({crash})

Trunk
mozilla1.9.3a2
x86
Linux
crash
Points:
---

Firefox Tracking Flags

(status1.9.2 .2-fixed, status1.9.1 .9-fixed)

Details

(crash signature)

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 412561 [details] [diff] [review]
patch

downstream bug - https://bugzilla.redhat.com/show_bug.cgi?id=537519

Broken plug-in can pass NULL npp instance to _pushpopupsenabledstate()/_pushpopupsenabledstate()
(Assignee)

Updated

8 years ago
Attachment #412561 - Attachment is patch: true
Attachment #412561 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Updated

8 years ago
Attachment #412561 - Flags: review?(jst)
(Assignee)

Updated

8 years ago
Keywords: crash

Updated

8 years ago
Attachment #412561 - Flags: review?(jst) → review+
Assignee: nobody → stransky
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/00cef42f43bf
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 412561 [details] [diff] [review]
patch

Worth taking on the stable branches?
Attachment #412561 - Flags: approval1.9.2.2?
Attachment #412561 - Flags: approval1.9.1.9?
Attachment #412561 - Flags: approval1.9.2.2?
Attachment #412561 - Flags: approval1.9.2.2+
Attachment #412561 - Flags: approval1.9.1.9?
Attachment #412561 - Flags: approval1.9.1.9+
Comment on attachment 412561 [details] [diff] [review]
patch

Approved for 1.9.1.9 and 1.9.2.2, a=dveditz for release-drivers
I'll check this in myself later this week, but anyone wants to get to it first :-)
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9db2d72c8b33
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/85b4a2191d72
status1.9.1: --- → .9-fixed
status1.9.2: --- → .2-fixed
Keywords: checkin-needed
Is there a way for QA to test or verify this fix, especially for 1.9.2?

Comment 7

7 years ago
the original bug seems to have been using plugin wrapper. i think it'd be easier to change a test plugin to call:

NPN_pushpopupsenabledstate(NULL)

it should either crash or not crash.
(Assignee)

Comment 8

7 years ago
Created attachment 434194 [details]
testcase

A testcase. Build the plugin and copy it to plugin directory, restart browser and open bundled test.html page. Browser should not crash.
Crash Signature: [@ _pushpopupsenabledstate() ]
You need to log in before you can comment on or make changes to this bug.