Closed
Bug 528900
Opened 15 years ago
Closed 14 years ago
crash [@ _pushpopupsenabledstate() ]
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(status1.9.2 .2-fixed, status1.9.1 .9-fixed)
RESOLVED
FIXED
mozilla1.9.3a2
People
(Reporter: stransky, Assigned: stransky)
Details
(Keywords: crash)
Crash Data
Attachments
(2 files)
1.22 KB,
patch
|
jst
:
review+
dveditz
:
approval1.9.2.2+
dveditz
:
approval1.9.1.9+
|
Details | Diff | Splinter Review |
4.51 KB,
application/x-gzip
|
Details |
downstream bug - https://bugzilla.redhat.com/show_bug.cgi?id=537519 Broken plug-in can pass NULL npp instance to _pushpopupsenabledstate()/_pushpopupsenabledstate()
Assignee | ||
Updated•15 years ago
|
Attachment #412561 -
Attachment is patch: true
Attachment #412561 -
Attachment mime type: application/octet-stream → text/plain
Assignee | ||
Updated•15 years ago
|
Attachment #412561 -
Flags: review?(jst)
Updated•14 years ago
|
Attachment #412561 -
Flags: review?(jst) → review+
Updated•14 years ago
|
Assignee: nobody → stransky
Updated•14 years ago
|
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/00cef42f43bf
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 412561 [details] [diff] [review] patch Worth taking on the stable branches?
Attachment #412561 -
Flags: approval1.9.2.2?
Attachment #412561 -
Flags: approval1.9.1.9?
Updated•14 years ago
|
Attachment #412561 -
Flags: approval1.9.2.2?
Attachment #412561 -
Flags: approval1.9.2.2+
Attachment #412561 -
Flags: approval1.9.1.9?
Attachment #412561 -
Flags: approval1.9.1.9+
Comment 3•14 years ago
|
||
Comment on attachment 412561 [details] [diff] [review] patch Approved for 1.9.1.9 and 1.9.2.2, a=dveditz for release-drivers
I'll check this in myself later this week, but anyone wants to get to it first :-)
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9db2d72c8b33 http://hg.mozilla.org/releases/mozilla-1.9.1/rev/85b4a2191d72
Comment 6•14 years ago
|
||
Is there a way for QA to test or verify this fix, especially for 1.9.2?
the original bug seems to have been using plugin wrapper. i think it'd be easier to change a test plugin to call: NPN_pushpopupsenabledstate(NULL) it should either crash or not crash.
Assignee | ||
Comment 8•14 years ago
|
||
A testcase. Build the plugin and copy it to plugin directory, restart browser and open bundled test.html page. Browser should not crash.
Updated•13 years ago
|
Crash Signature: [@ _pushpopupsenabledstate() ]
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•