Closed Bug 528900 Opened 10 years ago Closed 10 years ago
crash [@ _pushpopupsenabledstate() ]
downstream bug - https://bugzilla.redhat.com/show_bug.cgi?id=537519 Broken plug-in can pass NULL npp instance to _pushpopupsenabledstate()/_pushpopupsenabledstate()
Attachment #412561 - Flags: review?(jst)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 412561 [details] [diff] [review] patch Worth taking on the stable branches?
Comment on attachment 412561 [details] [diff] [review] patch Approved for 126.96.36.199 and 188.8.131.52, a=dveditz for release-drivers
I'll check this in myself later this week, but anyone wants to get to it first :-)
Is there a way for QA to test or verify this fix, especially for 1.9.2?
the original bug seems to have been using plugin wrapper. i think it'd be easier to change a test plugin to call: NPN_pushpopupsenabledstate(NULL) it should either crash or not crash.
A testcase. Build the plugin and copy it to plugin directory, restart browser and open bundled test.html page. Browser should not crash.
Crash Signature: [@ _pushpopupsenabledstate() ]
You need to log in before you can comment on or make changes to this bug.