Closed Bug 528900 Opened 10 years ago Closed 10 years ago

crash [@ _pushpopupsenabledstate() ]

Categories

(Core :: Plug-ins, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.3a2
Tracking Status
status1.9.2 --- .2-fixed
status1.9.1 --- .9-fixed

People

(Reporter: stransky, Assigned: stransky)

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

Attached patch patchSplinter Review
downstream bug - https://bugzilla.redhat.com/show_bug.cgi?id=537519

Broken plug-in can pass NULL npp instance to _pushpopupsenabledstate()/_pushpopupsenabledstate()
Attachment #412561 - Attachment is patch: true
Attachment #412561 - Attachment mime type: application/octet-stream → text/plain
Attachment #412561 - Flags: review?(jst)
Keywords: crash
Attachment #412561 - Flags: review?(jst) → review+
Assignee: nobody → stransky
http://hg.mozilla.org/mozilla-central/rev/00cef42f43bf
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a2
Comment on attachment 412561 [details] [diff] [review]
patch

Worth taking on the stable branches?
Attachment #412561 - Flags: approval1.9.2.2?
Attachment #412561 - Flags: approval1.9.1.9?
Attachment #412561 - Flags: approval1.9.2.2?
Attachment #412561 - Flags: approval1.9.2.2+
Attachment #412561 - Flags: approval1.9.1.9?
Attachment #412561 - Flags: approval1.9.1.9+
Comment on attachment 412561 [details] [diff] [review]
patch

Approved for 1.9.1.9 and 1.9.2.2, a=dveditz for release-drivers
I'll check this in myself later this week, but anyone wants to get to it first :-)
Keywords: checkin-needed
Is there a way for QA to test or verify this fix, especially for 1.9.2?
the original bug seems to have been using plugin wrapper. i think it'd be easier to change a test plugin to call:

NPN_pushpopupsenabledstate(NULL)

it should either crash or not crash.
Attached file testcase
A testcase. Build the plugin and copy it to plugin directory, restart browser and open bundled test.html page. Browser should not crash.
Crash Signature: [@ _pushpopupsenabledstate() ]
You need to log in before you can comment on or make changes to this bug.