528903 - Stub reports missing Microsoft CRT DLL

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Matthew Gertner]

When the Prisms stub is run on Windows, it reports that MSVCR80.DLL is missing using a modal dialog. Once the dialog is closed, the app starts normally. The same thing occurs when building with VS 2008 except it reports MSVCR90.DLL is missing.

Comment 1

[Matthew Gertner]

Attachment: Specify dynamic linkage to CRT for Prism stub

The problem is that the stub links to the CRT statically. This means that the DLL dependencies are not added to the stub manifest. If the stub loads Mozilla DLLs dynamically that have DLL dependencies on the CRT (e.g. NSPR), the problem ensues. Specifically, the Prism binary components have NSPR dependencies and thus depend indirectly on the CRT DLLs. This patch specifies that the stub should link dynamically to the CRT, which causes the correct manifest to be generated.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 412564 [details] [diff] [review]
Specify dynamic linkage to CRT for Prism stub

Does this only affect the CRT? It doesn't affect the linkage of any other DLLs?

Comment 3

[Matthew Gertner]

(In reply to comment #2)
> (From update of attachment 412564 [details] [diff] [review])
> Does this only affect the CRT? It doesn't affect the linkage of any other DLLs?

Looks that way to me. See http://mxr.mozilla.org/mozilla1.9.1/source/config/config.mk#543

Comment 4

[Matthew Gertner]

Sending        client/stub/Makefile.in
Transmitting file data .
Committed revision 59103.

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I'm getting the described error on 1.0b3pre.

Comment 6

[Matthew Gertner]

(In reply to comment #5)
> I'm getting the described error on 1.0b3pre.

If you're getting this with the latest version I posted on my blog, please let me know. That would be very surprising.

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #6)
> (In reply to comment #5)
> > I'm getting the described error on 1.0b3pre.
> 
> If you're getting this with the latest version I posted on my blog, please let
> me know. That would be very surprising.

Confirming: latest version has this fixed now.