Closed Bug 529151 Opened 15 years ago Closed 15 years ago

Remove obsolete calls to suppressFocusScroll

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

Bug #178324 made suppressFocusScroll a no-operation. We need to switch tabbrowser over to using the new focus manager instead.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #412721 - Flags: review?(iann_bugzilla)
Attachment #412721 - Flags: review?(iann_bugzilla) → review+
Pushed changeset f8a53324d1af to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Could this fix be ported to the comm-1.9.1 branch?  On rare occasions when using SeaMonkey 2.0 on Vista, I see this message in the Error Console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMWindowUtils.focus]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://navigator/content/tabbrowser.xml :: setFocus :: line 979"  data: no]

When this happens, named anchor links temporarily stop functioning.  I can't reliably reproduce the bug, but it seems to be directly related to the obsolete code that was removed by this patch.
Attachment #412721 - Flags: approval-seamonkey2.0.1?
Comment on attachment 412721 [details] [diff] [review]
Proposed patch

No focus manager on 1.9.1 which is why we're using window utils.
Attachment #412721 - Flags: approval-seamonkey2.0.1? → approval-seamonkey2.0.1-
Oh, I see.  Thanks for clearing that up.
You need to log in before you can comment on or make changes to this bug.