529401 - Remove files on downgrade to prevent breaking Firefox

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Attachment: patch

There are several files that will break Firefox if the user does a pave over install on Windows (damn you pave over install!!!).

Comment 1

[(not currently active) Ted Mielczarek]

This patch is intended to land only on 1.9.1, right?

Comment 2

[Robert Strong (they/them - no direct email)]

Yep

Comment 3

[Daniel Veditz [:dveditz]]

Argh, we should have gotten this into 1.9.1.6.

And do we need it on 1.9.0 as well?

Comment 4

[Samuel Sidler (old account; do not CC)]

We need this in 1.9.1.6. And we should probably take it on 1.9.0 too. Rob, can we get this landed tonight if I approve it now?

Comment 5

[Robert Strong (they/them - no direct email)]

I can get it landed tonight.

Comment 6

[Samuel Sidler (old account; do not CC)]

Comment on attachment 412953 [details] [diff] [review]
patch

Approved for 1.9.1.6, 1.9.1.7, 1.9.0.16, and 1.9.0.17. a=ss for release-drivers

Please land ASAP on GECKO190_20091130_RELBRANCH (CVS) and GECKO1916_20091130_RELBRANCH (hg). Then land on CVS head and mozilla-1.9.1.

Comment 7

[Robert Strong (they/them - no direct email)]

Pushed to GECKO1916_20091130_RELBRANCH
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/27f8137dc8d2

and

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0cacfb2591f6

I need to CVS checkout to do the rest

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to CVS GECKO190_20091130_RELBRANCH
Checking in mozilla/browser/installer/removed-files.in;
/cvsroot/mozilla/browser/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.51.8.1; previous revision: 1.51
done

Comment 9

[Robert Strong (they/them - no direct email)]

Will land on CVS HEAD shortly

Comment 10

[Robert Strong (they/them - no direct email)]

Pushed to CVS HEAD
Checking in mozilla/browser/installer/removed-files.in;
/cvsroot/mozilla/browser/installer/removed-files.in,v  <--  removed-files.in
new revision: 1.52; previous revision: 1.51
done