529441 - Build with -Werror=return-type

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This would cause the buggy program

int foo() {
}

to produce an error instead of

ret.c: In function ‘foo’:
ret.c:2: warning: control reaches end of non-void function

I've accidentally missed that warning a several times on first compile.  I feel quite confident in stating that there's *no* plausible exception to this being an error.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: add -Werror=return-type configure.in test

Unsurprisingly this didn't find any existing bugs.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 412990 [details] [diff] [review]
add -Werror=return-type configure.in test

Is this flag not supported by all versions of GCC that we care about? If it's relatively new then this is fine. If it's been around for a long time, then you could just stick it in the unconditional list of _WARNINGS_CXXFLAGS up above.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

My OS X/gcc setup (10.5/4.0) doesn't support -Werror=*.  I imagine this is a common dev configuration.

I imagine that if we start accumulation -Werror= flags (there's another open bug to add -Werror=hidden-virtual), we'd want a single test for -Werror=* support and then just stick all those in _WARNINGS_CXXFLAGS.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/mozilla-central/rev/a9addb7dc548