529679 - js shell cmd evalcx regression due to uninitialized variable

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brendan Eich [:brendan]]

Attachment: fix

[3:36pm] brendan: jorendorff: js1_8_1/extensions/regress-466905-05.js seems bogus -- it's failing with my rebased patch for 473228 (will test tm tip, perhaps it fails there too)
[3:36pm] brendan: bc may know
[3:41pm] jorendorff: brendan: that might be mrbkap's fault
[3:42pm] brendan: jorendorff: mrkbap calls JS_ClearScope, yeah
[3:42pm] jorendorff: brendan: I don't think JSBool split; is initialized properly
[3:42pm] brendan: that calls js_GenerateShape
[3:42pm] jorendorff: in jsshell.cpp:EvalInContext
[3:42pm] brendan: jorendorff: saw that warning, mailed mrbkap about it
[3:42pm] brendan: mrbkap around
[3:43pm] brendan: jorendorff: you're right, split in EvalInContext is non-zero garbage
[3:43pm] brendan: mrbkap spending too much time with the mlle.'s and the fine wine 
[3:43pm] jorendorff: brendan: yep - just fix that, mrbkap didn't mean to change the behavior for 'lazy'

/be

Comment 1

[Brendan Eich [:brendan]]

http://hg.mozilla.org/tracemonkey/rev/f3b2492321e6

/be

Comment 2

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/f3b2492321e6