Port |Bug 407875 - Unprivileged users are not notified of security updates| to SeaMonkey, re-enable 'Check for Updates'

RESOLVED FIXED in seamonkey2.1a1

Status

SeaMonkey
General
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: rstrong, Assigned: mcsmurf)

Tracking

({fixed-seamonkey2.0.6})

Trunk
seamonkey2.1a1
fixed-seamonkey2.0.6

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

I'm hoping to land bug 407875 on the 1.9.2 branch. The patches in bug 407875 should be enough to go on and don't hesitate to ping me on irc if there are any questions
Note: Bug 529942 will move (hopefully soon) the two new attributes from nsIApplicationUpdateService2 to nsIApplicationUpdateService on trunk

Comment 2

8 years ago
(In reply to comment #1)
> Note: Bug 529942 will move (hopefully soon) the two new attributes from
> nsIApplicationUpdateService2 to nsIApplicationUpdateService on trunk
Ah, the sweet smell of #ifdef ;-)
(Assignee)

Comment 3

8 years ago
Created attachment 416757 [details] [diff] [review]
Patch

From what I see this is everything that needs to be ported.
(Assignee)

Comment 4

8 years ago
Created attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]
Attachment #416757 - Attachment is obsolete: true

Updated

8 years ago
Attachment #416764 - Flags: superreview+

Updated

7 years ago
Duplicate of this bug: 536057

Updated

7 years ago
Keywords: checkin-needed
Attachment #416764 - Flags: review?(neil)
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 6

7 years ago
How are you expecting me to review this? I don't use nightlies.
(In reply to comment #6)
> How are you expecting me to review this? I don't use nightlies.

This bug had checkin-needed. But it looked like this patch needed a review first.
Doesn't it? Or who could review it?
Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]


[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20091219 SeaMonkey/2.1a1pre] (2009-12-19-00-comm-central-trunk) (W2Ksp4)

This patch fixes it for me.
(Assignee)

Comment 9

7 years ago
The patch already had sr+ ...?
See Also: → bug 536078
Summary: Port bug Bug 407875 to SeaMonkey so unprivileged users are notified / can check for updates → Port |Bug 407875 - Unprivileged users are not notified of security updates| to SeaMonkey, re-enable 'Check for Updates'
Depends on: 536078
See Also: bug 536078

Updated

7 years ago
No longer depends on: 536078
See Also: → bug 536078
Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]

r=me based on your test.
Attachment #416764 - Flags: review?(neil) → review+
Comment on attachment 416764 [details] [diff] [review]
Better Patch
[Checkin: Comment 11]


http://hg.mozilla.org/comm-central/rev/d87bb12163c6
Attachment #416764 - Attachment description: Better Patch → Better Patch [Checkin: Comment 11]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a1
Flags: blocking-seamonkey2.0.5?

Comment 12

7 years ago
Serge, what here is supposed to block 2.0.5? I don't see any comment here that implies why it should block, that it affects 1.9.1 at all, or what the risk is to ship a 2.0.x release with this.

Until that is cleared up, canceling the request, please re-nominate with those questions answered if there is an actual good reason.
Flags: blocking-seamonkey2.0.5?
Created attachment 448268 [details] [diff] [review]
branch patch [Checkin: comment 16]

(In reply to comment #12)
> I don't see any comment here that implies (...) that it affects 1.9.1 at all

1. the parent bug landed on 1.9.1 as well:
<http://hg.mozilla.org/releases/mozilla-1.9.1/rev/b9e025a5f582>
which implies two things:
 1.1. branch is/was (SM/FF) affected as well
 1.2. the Toolkit dependencies are already met on branch. I cannot really estimate the importance of the firefox-branding.js change, though.

2. with both SM 2.0(.0) release and the latest 2.0 nightly, Help>Check for Updates is grayed out if the application directory is not writable for the user who runs SeaMonkey (just checked in my Linux VM). If it is writable, or with the patch, the label is shown as normal and clickable. With the patch, if the user clicks the label, an update check is made. If an update is found but the user doesn't have write permissions to the application directory, a message is shown that explains just that.

> or what the risk is to ship a 2.0.x release with this.

I cannot answer that, only that it's probably fixed for FF but not for us.
Attachment #448268 - Flags: superreview?(neil)
Attachment #448268 - Flags: review?(neil)
Attachment #448268 - Flags: approval-seamonkey2.0.6?
Comment on attachment 448268 [details] [diff] [review]
branch patch [Checkin: comment 16]

r=me based on code inspection; it would help if someone else could test this.
Attachment #448268 - Flags: superreview?(neil)
Attachment #448268 - Flags: superreview+
Attachment #448268 - Flags: review?(neil)
Attachment #448268 - Flags: review+
(Assignee)

Comment 15

7 years ago
(In reply to comment #14)
> (From update of attachment 448268 [details] [diff] [review])
> r=me based on code inspection; it would help if someone else could test this.

Patch works fine, I tested it with a branch nightly build.

Updated

7 years ago
Attachment #448268 - Flags: approval-seamonkey2.0.6? → approval-seamonkey2.0.6+
Comment on attachment 448268 [details] [diff] [review]
branch patch [Checkin: comment 16]

http://hg.mozilla.org/releases/comm-1.9.1/rev/76ee166a7d08
Attachment #448268 - Attachment description: branch patch → branch patch [Checkin: comment 16]
Keywords: fixed-seamonkey2.0.6
You need to log in before you can comment on or make changes to this bug.