Closed
Bug 529749
Opened 15 years ago
Closed 15 years ago
Ensure that rulewalkers never have a null rulenode
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 1 obsolete file)
|
15.47 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Basically makes Transition() return |this| instead of null on OOM. That ensures that rulewalkers never have a null mCurrent.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #413276 -
Flags: review?(dbaron)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #413276 -
Attachment is obsolete: true
Attachment #413277 -
Flags: review?(dbaron)
Attachment #413276 -
Flags: review?(dbaron)
Comment on attachment 413277 [details] [diff] [review]
With one more callsite fixed
Could you make the sites in nsRuleNode::Transition that return early on out-of-memory have NS_WARNING("out of memory") so that we'll notice if somebody changes code such that we hit one by accident?
r=dbaron
Attachment #413277 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
> NS_WARNING("out of memory")
Done.
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•