529813 - Invite Attendees dialog: icons are messed up in case of missing participation role

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Stefan Sitter [:ssitter]]

Attachment: sample ics file

Lightning 1.0pre (20091118) with Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5) Gecko/20091119 Shredder/3.0.1pre

In case of an attendee without participation role the icons in the Invite Attendees dialog are messed up. This issue has been reported in the German forum <http://www.sunbird-kalender.de/forum/viewtopic.php?f=8&t=2853>.

Steps to reproduce:
1. Import the attached sample ics file
2. Edit the event and open the Invite Attendees dialog
3. Check list of attendees on the left

Actual result:
Icons are messed up for the fourth attendee, see attached screenshot.

Expected result:
Do not break display on missing participation role.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: screenshot

Comment 2

[Stefan Sitter [:ssitter]]

Currently we always set the role icon regardless if role is set or if role is undefined. <http://mxr.mozilla.org/comm-central/source/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml#371>

RFC 5545 states the following for Participation Role:

  > If not specified on a property that allows this parameter, the
  > default value is REQ-PARTICIPANT. Applications MUST treat x-name and
  > iana-token values they don't recognize the same way as they would the
  > REQ-PARTICIPANT value.

So the correct behavior would be to display the REQ-PARTICIPANT icon.

Comment 3

[Decathlon]

Hence, the right behavior should be to show the "REQ-PARTICIPANT" icon in the dialog when the event (that comes from another calendar application) doesn't have the role or has a bad role not included in specifications.

But should Lightning change the bad role stored in the calendar to the default one ("REQ-PARTICIPANT") only when the user opens the attendee dialog or should it change just after the invitation has been accepted?
Or should this be only a problem that concerns the icon showed in the dialog but not the role value stored in the calendar (Lightning shows the REQ-PARTICIPANT icon but stores the original role value, even if wrong)?

Comment 6

[Simon Vaillancourt]

Attachment: Fallback to REQ-PARTICIPANT if ROLE is undefined

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fallback using CSS instead

I'd prefer we fix this on the CSS side to allow potential userChrome.css to differ between a not specified role and the REQ-PARTICIPANT role.

Please test this in a real environment, I only did a basic smoketest. Feel free to adapt if I did something wrong.

Comment 8

[Simon Vaillancourt]

Attachment: [checked in] Fixed role attribute not set properly and add loading of the needed calendar-ui-utils script

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 431655 [details] [diff] [review]
[checked in] Fixed role attribute not set properly and add loading of the needed calendar-ui-utils script

r=philipp

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/27da2a32b708>

-> FIXED

Comment 11

[Decathlon]

Does the patch need the pinstripe part for the file calendar-event-dialog.css?

I've tried the latest nightly, and I've seen that the icon related to the last attendee (see ics calendar attached) doesn't change when clicking on it, even changing the attendee with a new one that has a  "Needs action" status (but again without a role) e.g.

ATTENDEE;RSVP=TRUE;CN=Daniel XXXXX;PARTSTAT=NEEDS-ACTION:mailto:[e-mail]

Is it the right behavior?

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Duh, of course it needs a pinstripe change :-( I really need to get bug 533096 fixed soon, this has happened to me more than once lately! I'll also fix the other bug while I'm at it, thanks for noticing!

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Regression Fix - v1

Comment 15

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/a6d254943619>

-> FIXED