529819 - Can't submit forms on Logitech Website

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Sylvain Pasche]

Attachment: testcase, needs reduction

This is a regression in Firefox 3.6 and 3.7. The Logitech Support website uses forms that can't be submitted with Firefox 3.6. The form works fine with Firefox 3.5 or other browsers.

Steps to reproduce:
1) Extract the attached archive and load the html file
2) Click on "Save Changes"
Expected:
 You should see an alert with the message: 'Preferred Language' requires a value.
Actual:
 An alert with: An email address must be unique across the Email Address, Email Alt 1, and Email Alt 2 fields.

On 3.6 and later, document.forms[1].p_email returns a NodeList with 2 identical nodes representing the email input.
On 3.5 it returns a single node with the email input.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=566ec4a87812&tochange=78fa6be2aac1

Almost certainly a regression from bug 332893.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 413408 [details] [diff] [review]
Fix

>       if(nsContentUtils::PositionIsBefore(list->GetNodeAt(list->Length() - 1), aChild)) {
>           list->AppendElement(aChild);
>           return NS_OK;
>       }
Um, this method seems to mix 2 and 4 space indentation.
Want to fix that while you're here? Also the 'while (last != first) {' a bit later in the
method.

In any case, r=me.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> Um, this method seems to mix 2 and 4 space indentation.

Fixed, for both.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/6deaa5b2b2d8

Comment 6

[Boris Zbarsky [:bzbarsky]]

Er, I meant http://hg.mozilla.org/mozilla-central/rev/54cf88d09819

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: 1.9.2 branch merge

Comment 8

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/releases/mozilla-1.9.2/rev/71678ba20f93