xpcshell-tests in /mailnews/compose fail on JS strict mode

RESOLVED FIXED in Thunderbird 3.1a1

Status

--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: lusian, Assigned: lusian)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 3.1a1
x86
Windows XP
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091119 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: 

xpcshell unit tests in /mailnews/compose fail on JS strict mode.

Reproducible: Always
(Assignee)

Updated

9 years ago
Blocks: 524781
(Assignee)

Comment 1

9 years ago
Created attachment 413561 [details] [diff] [review]
Fix JS strict warnings
Attachment #413561 - Flags: review?(neil)
Assignee: nobody → lusian
Severity: trivial → minor
Status: UNCONFIRMED → ASSIGNED
Component: General → Composition
Ever confirmed: true
Product: Testing → MailNews Core
QA Contact: general → composition
Target Milestone: --- → Thunderbird 3.1a1
Version: unspecified → Trunk

Comment 2

9 years ago
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings

r=me by code inspection
Attachment #413561 - Flags: review?(neil) → review+
(Assignee)

Updated

9 years ago
Attachment #413561 - Flags: superreview?(dmose)
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings

You don't need sr for test-only patches.
Attachment #413561 - Flags: superreview?(dmose)
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/25bbfb919e50
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings


"approval-thunderbird3.0.1=?":
No risk, test only.
Attachment #413561 - Flags: approval-thunderbird3.0.1?
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings

There's no fixes here and this is test-only, so there is zero benefit to taking this on 1.9.1.
Attachment #413561 - Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1-
You need to log in before you can comment on or make changes to this bug.