Closed
Bug 530034
Opened 16 years ago
Closed 16 years ago
xpcshell-tests in /mailnews/compose fail on JS strict mode
Categories
(MailNews Core :: Composition, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1a1
People
(Reporter: lusian, Assigned: lusian)
References
Details
Attachments
(1 file)
|
5.56 KB,
patch
|
neil
:
review+
standard8
:
approval-thunderbird3.0.1-
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091119 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier:
xpcshell unit tests in /mailnews/compose fail on JS strict mode.
Reproducible: Always
|
Assignee | |
Comment 1•16 years ago
|
||
Attachment #413561 -
Flags: review?(neil)
|
||
Updated•16 years ago
|
Assignee: nobody → lusian
Severity: trivial → minor
Status: UNCONFIRMED → ASSIGNED
Component: General → Composition
Ever confirmed: true
Product: Testing → MailNews Core
QA Contact: general → composition
Target Milestone: --- → Thunderbird 3.1a1
Version: unspecified → Trunk
|
||
Comment 2•16 years ago
|
||
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings
r=me by code inspection
Attachment #413561 -
Flags: review?(neil) → review+
|
|
Assignee | |
Updated•16 years ago
|
Attachment #413561 -
Flags: superreview?(dmose)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings
You don't need sr for test-only patches.
Attachment #413561 -
Flags: superreview?(dmose)
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite+
Keywords: checkin-needed
Resolution: --- → FIXED
|
|
||
Comment 5•16 years ago
|
||
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings
"approval-thunderbird3.0.1=?":
No risk, test only.
Attachment #413561 -
Flags: approval-thunderbird3.0.1?
|
|
||
Comment 6•16 years ago
|
||
Comment on attachment 413561 [details] [diff] [review]
Fix JS strict warnings
There's no fixes here and this is test-only, so there is zero benefit to taking this on 1.9.1.
Attachment #413561 -
Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1-
You need to log in
before you can comment on or make changes to this bug.
Description
•