530046 - Investigate getting crash-stacks for xpcshell tests

Status: RESOLVED WORKSFORME

(Mozilla Messaging Graveyard :: Release Engineering, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Story so far:

- We have a consistent crasher on trunk (bug 529668).
- We removed a local override which meant that make buildsymbols wasn't happening.
- We added -gstabs+ to the CFLAGS and CXXFLAGS for Linux and clobbered (http://hg.mozilla.org/build/buildbot-configs/rev/617fae88e177).

We still get no crashes.

My current thoughts:

1) Need to add -gdwarf-2 to the CFLAGS and CXXFLAGS to Mac unit test mozconfigs.
2) Need to add export MOZILLA_OFFICIAL=1 to all the unit test mozconfigs.
3) Need to set MOZ_CRASHREPORTER_NO_REPORT=1 in the environment for the unit test mozconfigs.

Firefox don't seem to do items 2 and 3 in their release unit test set up, but based on my work with the bloat boxes and the fact that I've seen both Mac and Windows use their own crash reporting systems, I'm pretty sure that both of these should in fact be set.

The attached patch should do 1-3 and hopefully that will fix this bug (obviously buildbot will need a reconfig and I expect we'll need to clobber at least the mac builds).

Comment 1

[(not currently active) Ted Mielczarek]

What unit tests are you hitting this on? We don't do #2 or #3 because the unit test harnesses do it for us:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#448

(setting MOZ_CRASHREPORTER=1 at runtime is equivalent to setting MOZILLA_OFFICIAL at build time)

Comment 2

[Mark Banner (:standard8)]

I've been talking to ted over irc about this.

It turns out that in non-libxul builds we haven't got one of the required items registered, and therefore crash reporter can't start - this is covered in bug 475965.

So unless we fix that (or do some sort of workaround) or make Thunderbird capable of building with libxul, then we can't actually fix this bug.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 413575 [details] [diff] [review]
The fix

Although we'll probably still want some of the mozconfig changes for mozmill, this patch obviously isn't going to do the job.

Comment 5

[Mark Banner (:standard8)]

We're now running xpcshell-tests in libxul packaged form on trunk and try server, so we get stacks for free now :-)