530072 - Unable to build crashreporter due to missing #include <stdio.h> in Linux

Status: RESOLVED DUPLICATE of bug 510920

(Toolkit :: Crash Reporting, defect)

Description

[Jan Horak [:jhorak]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091105 Fedora/3.5.5-1.fc12 Firefox/3.5.5
Build Identifier: 

A stdio.h include is missing in crashreporter source code.

gcc 4.4.2

Reproducible: Always

Comment 1

[Jan Horak [:jhorak]]

Attachment: Proposed fix

Comment 2

[Benjamin Smedberg]

Please file and fix google-breakpad issues upstream in their issue tracker, we don't take local patches (although I thought this was already fixed on trunk, does it just need a branch backport?)

Comment 3

[(not currently active) Ted Mielczarek]

yes. see bug 510920 comment 21.

Comment 4

[Alexey Gladkov]

This bug is actual for releases/mozilla-1.9.2.

c++ -o dump_symbols.o -c -I../../../../../../dist/system_wrappers -include ../../../../../../config/gcc_hidden.h -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I./../.. -I. -I. -I../../../../../../dist/include -I../../../../../../dist/include/nsprpub  -I/usr/include/nspr -I/usr/include/nss         -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -pipe -Wall -O2 -march=pentium4 -fPIC -DPIC -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -O2   -DMOZILLA_CLIENT -include ../../../../../../mozilla-config.h -Wp,-MD,.deps/dump_symbols.pp dump_symbols.cc
dump_symbols.cc: In function 'bool<unnamed>::WriteFormat(int, const char*, ...)':
dump_symbols.cc:176: error: 'vsnprintf' was not declared in this scope
dump_symbols.cc: In function 'bool<unnamed>::ComputeSizeAndRVA(Elf32_Addr, <unnamed>::SymbolInfo*)':
dump_symbols.cc:487: error: 'stderr' was not declared in this scope
dump_symbols.cc:488: error: 'fprintf' was not declared in this scope

Comment 5

[(not currently active) Ted Mielczarek]

Yes, we know.