530146 - observe new notifications to know when users select lightweight themes

Status: RESOLVED FIXED

(Mozilla Labs Graveyard :: Personas Plus, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When the fix for bug 529769 lands, Personas will have to observe different notifications in order to know when users select lightweight themes.  It should switch to observing those notifications.

Comment 1

[Jose E. Bolanos]

Resolved in changeset:
http://hg.mozilla.org/labs/personas/rev/f0b8011c69ee

However, using the latest nightly build, the "lightweight-theme-changed" topic is *still being fired when themes are just being previewed*. The code in this changeset still works though.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #1)
> However, using the latest nightly build, the "lightweight-theme-changed" topic
> is *still being fired when themes are just being previewed*. The code in this
> changeset still works though.

The fix for bug was checked in last night, so I'd think today's night build would have the fix.  What's the user agent string of the build you're using to test it?

Comment 3

[Jose E. Bolanos]

(In reply to comment #2)
> (In reply to comment #1)
> > However, using the latest nightly build, the "lightweight-theme-changed" topic
> > is *still being fired when themes are just being previewed*. The code in this
> > changeset still works though.
> 
> The fix for bug was checked in last night, so I'd think today's night build
> would have the fix.  What's the user agent string of the build you're using to
> test it?

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b4) Gecko/20091124 Firefox/3.6b4

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #3)
> Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2b4)
> Gecko/20091124 Firefox/3.6b4

Hmm, that looks like a Firefox 3.6b4 candidate build from yesterday. Try today's nightly:

http://releases.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-1.9.2/firefox-3.6b5pre.en-US.mac.dmg

Comment 5

[Jose E. Bolanos]

Hmm... Can't open the link, 404. Can you check?

Comment 6

[Tony Chung [:tchung]]

(In reply to comment #5)
> Hmm... Can't open the link, 404. Can you check?

replace releases.mozilla.org with ftp.mozilla.org

Comment 7

[Jose E. Bolanos]

(In reply to comment #6)
> (In reply to comment #5)
> > Hmm... Can't open the link, 404. Can you check?
> 
> replace releases.mozilla.org with ftp.mozilla.org

Got it. I can confirm the observer topic is fired only when the theme is actually changed now.