530292 - xpcshell-tests in /mailnews/imap fail on JS strict mode

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Jae-Seong Lee-Russo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091120 Minefield/3.7a1pre (.NET CLR 3.5.30729)
Build Identifier: 

xpcshell unit tests fail or hang on the JavaScript strict mode.

Reproducible: Always

Comment 1

[Jae-Seong Lee-Russo]

Attachment: /mailnews/imap, 0

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/f57548d5951f

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 413806 [details] [diff] [review]
/mailnews/imap, 0


"approval-thunderbird3.0.1=?":
No risk, test only.

Comment 4

[David :Bienvenu]

please, we don't want to have to approve all these patches for the security and stability release.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> Checked in: http://hg.mozilla.org/comm-central/rev/f57548d5951f

Note that test_localToImapFilter.js should not be re-enabled (on branch): see bug 502928.

(In reply to comment #4)
> please, we don't want to have to approve all these patches for the security and
> stability release.

Maybe tests could be allowed to land without approval?

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 413806 [details] [diff] [review]
/mailnews/imap, 0

Not for 3.0.x. Not fixing anything apart from warnings in test code so not taking this.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Not fixing anything apart from warnings

May be right, but just to double check:
{
test_autosync_date_constraints.js
153 gMsgImapInboxFolder = null;

test_compactOfflineStore.js
87 gIMAPTrashFolder = gRootFolder.getChildNamed("Trash");
89 gIMAPTrashFolder.updateFolder(null);
201 gMsgImapInboxFolder = null;
}
look like they might be fixing something real (in the tests)...

Comment 8

[Jae-Seong Lee-Russo]

(In reply to comment #7)
Those fixes are only for strict mode.  3.0.x are fine without the fixes.