530311 - Make the bugzilla URL match other words than "bug"

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, enhancement)

Description

[worms]

Some bug tracking systems do not use "bug" as their keyword for naming individual bugs, but use:
- issue
- ticket.

It would be great if issue# and ticket# would be recognized as matching bug#, so an URL could link directly to them.

Comment 1

[Robert Utasi [:hunboy]]

Attachment: patch v1.0

Silver,

this one works with | separated keywords such as bug|issue|ticket

this comes from the RegExp.

I did not find way to make it network/channel dependent while this is hacking the munger itself, and we dont define own mungers for each channels.

the default value is: bug

the network/channel dependent overdefine of buglink works of course. I havent touched that.

Comment 2

[Robert Utasi [:hunboy]]

Attachment: graphical presentation

Comment 3

[Robert Utasi [:hunboy]]

Attachment: patch v1.0.1

Some English correction for label title at preferences (thnx to Neil to fix my english)

Comment 4

[James Ross]

Comment on attachment 8417136 [details] [diff] [review]
patch v1.0.1

Review of attachment 8417136 [details] [diff] [review]:
-----------------------------------------------------------------

Overall looks good; r=silver with the nits fixed.

Thanks and apologies for the delay!

::: locales/en-US/chrome/chatzilla.properties
@@ +1470,5 @@
>  pref.awayIdleMsg.help           = The away message ChatZilla will use when you go away.
>  pref.awayNick.label             = Nickname (away)
>  pref.awayNick.help              = This nickname will automatically be used when you mark yourself away, if different from 'Nickname'. You may leave this blank to not change nickname when going away.
> +pref.bugKeyword.label           = Bug Keywords
> +pref.bugKeyword.help            = You can define multiple issue tracker keywords by separating them with "|" e.g. bug|issue|case|ticket

Nit: I think this should explicitly state that the value is a regular expression.

::: xul/content/mungers.js
@@ +327,4 @@
>  
>      if (bugURL.length > 0)
>      {
> +        var idOrAlias = matchText.match(new RegExp("("+client.prefs["bugKeyword"]+")\\s+#?(\\d+|[^\\s,]{1,20})","i"))[2];

Nit: You could use (?: ... ) here as well and avoid changing [1] to [2].

Comment 5

[Robert Utasi [:hunboy]]

Attachment: patch v1.1

Nits fixed patch

Comment 6

[James Ross]

http://hg.mozilla.org/chatzilla/rev/f7a87dddcfdd