Closed
Bug 530313
Opened 15 years ago
Closed 15 years ago
libtheora fails to compile on mingw
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a1
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
378 bytes,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Makefile of libtheora assumes that compilation on WINNT target uses MSC compiler and always tries to compile x86_vc files. It should check compiler instead of OS_ARCH.
|
Assignee | |
Updated•15 years ago
|
Attachment #413825 -
Attachment is patch: true
Attachment #413825 -
Flags: review?(kinetik)
|
|
Assignee | |
Comment 1•15 years ago
|
||
Matthew, ping.
|
|
Assignee | |
Updated•15 years ago
|
Attachment #413825 -
Flags: review?(kinetik) → review?(ted.mielczarek)
|
||
Comment 2•15 years ago
|
||
You probably need to fix the other tests in the makefile so that you get the GCC-based assembly, at least if you care about decoding performance.
|
|
Assignee | |
Comment 3•15 years ago
|
||
(In reply to comment #2) > You probably need to fix the other tests in the makefile so that you get the > GCC-based assembly, at least if you care about decoding performance. I'm not sure what you mean. The check that my patch fixes is the only one in the Makefile and it includes GCC-based assembly to CSRCS just like any other GCC-based targets.
|
||
Updated•15 years ago
|
Attachment #413825 -
Flags: review?(ted.mielczarek) → review+
|
|
||
Updated•15 years ago
|
Assignee: nobody → jacek
|
||
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/a5c04f7bacd1
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in
before you can comment on or make changes to this bug.
Description
•