530414 - Some /mailnews/local/src/nsLocalMailFolder.cpp cleanup

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Serge Gautherie (:sgautherie)]

(I noticed this while working on bug 459693.)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Mostly "whitespaces", A few rewrites.

Comment 2

[David :Bienvenu]

Comment on attachment 413922 [details] [diff] [review]
(Av1) Mostly "whitespaces", A few rewrites.

sorry for the delay; this seems to have bit-rotted.

It all looks OK, except for this, which I don't think is an improvement in readability:

   return PR_FALSE;
-#endif
-  return NS_OK;
+#else
+  return NS_OK;
+#endif

also, since you touched these lines, you should remove the space after nsCOMPtr here:

+  nsCOMPtr <nsILocalFile> parentPathFile;
+  parentFolder->GetFilePath(getter_AddRefs(parentPathFile));

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Mostly "whitespaces", A few rewrites [Checkin: Comment 5]

Av1, with comment 2 suggestion(s).

Comment 4

[David :Bienvenu]

Comment on attachment 425605 [details] [diff] [review]
(Av2) Mostly "whitespaces", A few rewrites
[Checkin: Comment 5]

thx for the new patch.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 425605 [details] [diff] [review]
(Av2) Mostly "whitespaces", A few rewrites
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/20028fef3268