Closed Bug 530414 Opened 12 years ago Closed 11 years ago

Some /mailnews/local/src/nsLocalMailFolder.cpp cleanup

Categories

(MailNews Core :: Backend, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.1b1

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

Attachments

(1 file, 1 obsolete file)

(I noticed this while working on bug 459693.)
Attachment #413922 - Flags: superreview?(bienvenu)
Attachment #413922 - Flags: review?(bienvenu)
Comment on attachment 413922 [details] [diff] [review]
(Av1) Mostly "whitespaces", A few rewrites.

sorry for the delay; this seems to have bit-rotted.

It all looks OK, except for this, which I don't think is an improvement in readability:

   return PR_FALSE;
-#endif
-  return NS_OK;
+#else
+  return NS_OK;
+#endif

also, since you touched these lines, you should remove the space after nsCOMPtr here:

+  nsCOMPtr <nsILocalFile> parentPathFile;
+  parentFolder->GetFilePath(getter_AddRefs(parentPathFile));
Attachment #413922 - Flags: superreview?(bienvenu)
Attachment #413922 - Flags: superreview-
Attachment #413922 - Flags: review?(bienvenu)
Attachment #413922 - Flags: review-
Av1, with comment 2 suggestion(s).
Attachment #413922 - Attachment is obsolete: true
Attachment #425605 - Flags: superreview?(bienvenu)
Attachment #425605 - Flags: review?(bienvenu)
Attachment #425605 - Flags: superreview?(bienvenu)
Attachment #425605 - Flags: superreview+
Attachment #425605 - Flags: review?(bienvenu)
Attachment #425605 - Flags: review+
Comment on attachment 425605 [details] [diff] [review]
(Av2) Mostly "whitespaces", A few rewrites
[Checkin: Comment 5]

thx for the new patch.
Comment on attachment 425605 [details] [diff] [review]
(Av2) Mostly "whitespaces", A few rewrites
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/20028fef3268
Attachment #425605 - Attachment description: (Av2) Mostly "whitespaces", A few rewrites → (Av2) Mostly "whitespaces", A few rewrites [Checkin: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1b1
You need to log in before you can comment on or make changes to this bug.