Closed Bug 530534 Opened 16 years ago Closed 16 years ago

libxul-embedding*.pc lack -ldl

Categories

(Toolkit Graveyard :: XULRunner, defect)

1.9.1 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
(Not sure the component is the proper one) When linking against the xpcomglue static library, you are obviously going to require the dependency for dlopen() which is required on unix builds. -ldl should thus be added the pkg-config files for libxul-embedding and libxul-embedding-unstable.
Attachment #414049 - Attachment is patch: true
Attachment #414049 - Attachment mime type: application/octet-stream → text/plain
Attachment #414049 - Flags: review?(benjamin)
Attachment #414049 - Flags: review?(benjamin) → review+
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Component: Build Config → XULRunner
Keywords: checkin-needed
Product: Core → Toolkit
QA Contact: build-config → xulrunner
your patch has bitrotted
Keywords: checkin-needed
Attached patch Unbitrotted patch (obsolete) — Splinter Review
Is review needed in such cases ?
Attachment #414049 - Attachment is obsolete: true
Keywords: checkin-needed
Keywords: checkin-needed
Attached patch Patch v2Splinter Review
This is a brown paper bag change: the -ldl was not on the right line
Attachment #430859 - Attachment is obsolete: true
Attachment #438950 - Flags: review?(benjamin)
Attachment #438950 - Flags: review?(benjamin) → review+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: