Closed Bug 530657 Opened 15 years ago Closed 14 years ago

Docshell cleanup: Simplify code which takes nsIDOMDocument and then QIs that to nsIDocument.

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: justin.lebar+bug, Assigned: justin.lebar+bug)

References

Details

Attachments

(1 file)

There are many places in nsDocShell.cpp where we get an nsIDOMDocument and then QI that to an nsIDocument.

Many of these instances could be simplified by getting the nsIDocument directly.
This depends on bug 500328, because I added code in my patch there to allow nsDocShell::GetInterface to cast directly to nsIDocument.
Depends on: 500328
Attached patch Patch v1Splinter Review
Assignee: nobody → justin.lebar+bug
Status: NEW → ASSIGNED
Attachment #458384 - Flags: review?(jonas)
Attachment #458384 - Flags: approval2.0?
Attachment #458384 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/fb854ad5a86b
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: