530844 - Maemo L10n builders have to wget from "en-US" sub-directory

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

Attachment: [buildbotcustom] wget en-US binaries from "en-US" sub-directory

Last night the Maemo l10n builds started failing since there was no "en-US" tar ball under latest since it now lives under the "en-US" sub-directory.

Comment 1

[Armen [:armenzg]]

Attachment: [buildbotcustom] modify enUSBinaryURL only for Maemo L10n builds

The previous patch was affecting Desktop L10n builds which only upload to "latest".
This patch fixes Maemo L10n builds but does not affect Linux Desktop L10n builds.

Comment 2

[Chris Cooper [:coop] (he/him)]

Comment on attachment 414321 [details] [diff] [review]
[buildbotcustom] modify enUSBinaryURL only for Maemo L10n builds

enUSBinaryURL isn't a required param for MobileNightlyRepackFactory(), so you should check to make sure it exists in kwargs and isn't empty before applending to it.

Comment 3

[Armen [:armenzg]]

Attachment: [buildbotcustom] [buildbotcustom] modify enUSBinaryURL only for Maemo L10n builds (v2)

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 414349 [details] [diff] [review]
[buildbotcustom]  [buildbotcustom] modify enUSBinaryURL only for Maemo L10n builds (v2)

>+        if 'enUSBinaryURL' in kwargs:

Just make this an assert as well since it's mandatory.

r+ with that change.

Comment 5

[Armen [:armenzg]]

http://hg.mozilla.org/build/buildbotcustom/rev/201cda91a70b

Deployed and triggered "x-testing" nightly builds.

Comment 6

[Armen [:armenzg]]

All "x-testing" runs succeeded. I will check in the morning to see if there are anymore problems.

Comment 7

[Armen [:armenzg]]

They are wgetting from "en-US".

Aside of this I have noticed that when we do make wget-en-US we get this message:
"make: dpkg-architecture: Command not found"
which probably comes from this:
http://mxr.mozilla.org/mobile-browser/source/locales/Makefile.in#66
and this message appears since Nov.5th in the logs.

I assume this is the involved changeset:
http://hg.mozilla.org/mobile-browser/rev/1fbb7f70fddb

Axel anything to be done about it? or it doesn't matter?

Comment 8

[Chris Cooper [:coop] (he/him)]

(In reply to comment #7)
> Aside of this I have noticed that when we do make wget-en-US we get this
> message:
> "make: dpkg-architecture: Command not found"

I've seen this in my update testing, and I would expect to see this on platform that don't have the packaging tools. It's harmless, aside from polluting the properties a little on some platforms where STDOUT and STDERR get co-mingled.
If we really care about it, we could patch (or subclass) identToProperties() to ignore "make:" style errors.

Comment 9

[Aki Sasaki (not active)]

You can get around this by setting DEB_BUILD_ARCH.
http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#5175