530943 - Crash [@ nsIMEStateManager::OnTextStateFocus(nsPresContext*, nsIContent*)] in Firefox 3.6b3

Status: RESOLVED DUPLICATE of bug 529232

(Core :: Widget, defect)

Description

[Johnny Stenback (:jst)]

There's a new crash in Firefox 3.6b3 with the signature "nsIMEStateManager::OnTextStateFocus(nsPresContext*, nsIContent*)" in Firefox 3.6b3 that hasn't been seen in any of the versions 3\.5.*.

I looked at a sample of stack traces for this crash and they all seem to follow the pattern:

nsPrintProgress::OnStateChange() -> JS -> focus code -> process native messages -> focus code -> nsIMEStateManager::OnTextStateFocus().

Not sure where this belongs, trying widget first. Smaug, can you have an initial look at this?

Comment 1

[timeless]

This isn't really a regression, it's just bad code from bug 88831

robert@30529
500 nsresult rv = vm->GetRootWidget(getter_AddRefs(widget));
chenn@24836
501 NS_ENSURE_SUCCESS(rv, NS_ERROR_NOT_AVAILABLE);
chenn@24836
502
chenn@24836
503 rv = widget->OnIMEFocusChange(PR_TRUE); 

1841 NS_IMETHODIMP nsViewManager::GetRootWidget(nsIWidget **aWidget)
1842 {
1843   if (!mRootView) {
1844     *aWidget = nsnull;
1845     return NS_OK;


Signature	nsIMEStateManager::OnTextStateFocus(nsPresContext*, nsIContent*)
UUID	db4701c5-5e70-4441-9399-bf19c2091125
Time 	2009-11-25 01:13:02.128887
Uptime	1039
Last Crash	2826617 seconds before submission
Product	Firefox
Version	3.6b3
Build ID	20091115182845
Branch	1.9.2
OS	Windows NT
OS Version	6.1.7100
CPU	x86
CPU Info	GenuineIntel family 6 model 23 stepping 10
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0x0

Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsIMEStateManager::OnTextStateFocus 	content/events/src/nsIMEStateManager.cpp:503
1 	xul.dll 	xul.dll@0x3ff083 	
2 	xul.dll 	nsFocusManager::WindowRaised 	dom/base/nsFocusManager.cpp:683
3 	xul.dll 	nsWebShellWindow::HandleEvent 	xpfe/appshell/src/nsWebShellWindow.cpp:416
4 	xul.dll 	nsWindow::DispatchEvent 	widget/src/windows/nsWindow.cpp:2885
5 	xul.dll 	nsWindow::DispatchWindowEvent 	widget/src/windows/nsWindow.cpp:2913
6 	xul.dll 	nsWindow::DispatchFocus 	widget/src/windows/nsWindow.cpp:3383
7 	xul.dll 	nsWindow::ProcessMessage 	widget/src/windows/nsWindow.cpp:4152
8 	xul.dll 	nsWindow::WindowProc 	widget/src/windows/nsWindow.cpp:3501