530966 - New crash [@ nsDownloadScanner::~nsDownloadScanner()] in Firefox 3.6b3

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect, P1)

Description

[Johnny Stenback (:jst)]

There's a new crash in Firefox 3.6b3 with the signature "nsDownloadScanner::~nsDownloadScanner()" that hasn't been seen in any of the versions 3\.5.*. So far we've seen 29+ of these crashes in the wild.

Please see http://crash-stats.mozilla.com/query/query?product=Firefox&version=Firefox%3A3.6b3&range_value=1&range_unit=weeks&query_search=signature&query_type=exact&query=nsDownloadScanner%3A%3A%7EnsDownloadScanner%28%29&do_query=1 for more crash info.

Comment 1

[chris hofmann]

source around the second frame in the stack changed during 3.6 development

7124d9e94924
2009-08-11 12:37 -0500	Jim Mathies - Bug 504804 - Virus scanning prefs cleanup and smarter integration with win policy settings. r=tellrob, r=sdwilsh.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Gents: accusation levied! Care to comment? :)

Comment 3

[Rob Arnold [:robarnold]]

It seems very strange that a call to getService would cause a service to be released. I think mScanner is bogus so probably the nsDownloadManager is bogus?

Comment 4

[Jim Mathies [:jimm]]

I guess I'll take since I worked on it last.

Comment 5

[chris hofmann]

not much interesting in the url list...  lots of startup/restart and a few download pages and someone trying to grab a nightly build

  21 
  18 about:blank
  15 \N
  13 about:sessionrestore
   9 http://www.google.es/firefox
   8 http://www.google.de/
   4 http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-trunk/
   3 http://www.google.com.eg/firefox?client=firefox-a&rls=org.mozilla:en-US:official
   3 http://www.google.com.eg/
   3 http://tmf.myegy.com/2-ar.php?id=429309
   3 http://en-us.www.mozilla.com/en-US/firefox/3.6b3/whatsnew/
   2 https://banking.sparda.de/wps/portal/spardaclassic-banking
   2 http://www.google.pl/firefox?client=firefox-a&rls=org.mozilla:pl:official
   2 http://www.google.com/firefox?client=firefox-a&rls=org.mozilla:en-US:official
   2 http://www.google.com.vn/firefox?client=firefox-a&rls=org.mozilla:en-US:official
   2 http://www.google.cl/
   1 https://www.sparda-west.de/
   1 https://signin.ebay.com/ws/eBayISAPI.dll?SignIn&ru=http%3A%2F%2Fwww.ebay.com
   1 http://www.ziddu.com/download/7248193/MyEgy.CoM.Ehab.Tawfiek.Medly.Mr.DraCoLa.rmvb.html
   1 http://www.winamp.com/help/Player_Overview
   1 http://www.orbitdownloader.com/Grab-Pro.htm?r=install

Comment 6

[chris hofmann]

no reports on this signature during aug, sept, and oct up until 10/23.

0-2 crashes per day between then and the release of beta 1

 1   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091101
 0   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091102
 1   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091103
 0   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091104
 0   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091105
 5   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091106
 5   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091107
 2   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091108
32   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091109
 7   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091110
10   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091111
 7   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091112
 7   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091113
 4   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091114
 1   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091115
 6   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091116
 3   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091117
 5   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091118
10   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091119
 8   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091120
11   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091121
 3   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091122
19   total crashes for nsDownloadScanner::~nsDownloadScanner on 20091123

Comment 7

[timeless]

111 nsDownloadManager::GetSingleton()
112 {
113   if (gDownloadManagerService) {
114     NS_ADDREF(gDownloadManagerService);
115     return gDownloadManagerService;
116   }
117 
118   gDownloadManagerService = new nsDownloadManager();
119   if (gDownloadManagerService) {
120     NS_ADDREF(gDownloadManagerService);
121     if (NS_FAILED(gDownloadManagerService->Init()))
            ^- you might want to ask why you went the wrong way here.
122       NS_RELEASE(gDownloadManagerService);
          ^- you are here.

Signature	nsDownloadScanner::~nsDownloadScanner()
UUID	26fcee52-ce60-439d-a186-ecd832091124
Time 	2009-11-24 09:27:41.864393
Uptime	12
Last Crash	53 seconds before submission
Product	Firefox
Version	3.6b3
Build ID	20091115182845
Branch	1.9.2
OS	Windows NT
OS Version	5.1.2600 Service Pack 2
CPU	x86
CPU Info	GenuineIntel family 15 model 0 stepping 10
Crash Reason	EXCEPTION_ACCESS_VIOLATION
Crash Address	0xbc

Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	xul.dll 	nsDownloadScanner::~nsDownloadScanner 	toolkit/components/downloads/src/nsDownloadScanner.cpp:189
1 	xul.dll 	nsDownloadManager::~nsDownloadManager 	toolkit/components/downloads/src/nsDownloadManager.cpp:132
2 	xul.dll 	nsDownloadManager::`vector deleting destructor' 	
3 	xul.dll 	nsDownloadManager::Release 	toolkit/components/downloads/src/nsDownloadManager.cpp:106
4 	xul.dll 	xul.dll@0x42bfb2 	
5 	xul.dll 	nsDownloadManagerConstructor 	toolkit/components/build/nsToolkitCompsModule.cpp:86
6 	xul.dll 	nsGenericFactory::CreateInstance 	obj-firefox/xpcom/build/nsGenericFactory.cpp:80
7 	xul.dll 	nsComponentManagerImpl::CreateInstance 	xpcom/components/nsComponentManager.cpp:1597
8 	xul.dll 	nsComponentManagerImpl::GetService 	xpcom/components/nsComponentManager.cpp:1901
9 	xul.dll 	nsJSCID::GetService 	js/src/xpconnect/src/xpcjsid.cpp:894

Comment 8

[timeless]

Attachment: init early

Comment 9

[Shawn Wilsher :sdwilsh]

Comment on attachment 414472 [details] [diff] [review]
init early

r=sdwilsh

I should have caught this one in my original review of that change.  sadfaces all around...

Comment 10

[chris hofmann]

er, happy faces! jst's new crash finder saved us before we shipped a new crash.

Comment 11

[chris hofmann]

more eyeballs on the list at http://people.mozilla.com/~chofmann/crash-data/new-crashes/new-36b3-from-35x-as-of-20091122.html

can help return the favor to others.

Comment 12

[chris hofmann]

there is also a downloadwatchdog signature further down the list.

http://crash-stats.mozilla.com/report/list?product=Firefox&version=Firefox%3A3.6b3&query_search=signature&query_type=exact&date=&range_value=1&range_unit=weeks&do_query=1&signature=nsDownloadScannerWatchdog%3A%3AShutdown%28%29

same problem as this?

Comment 13

[Shawn Wilsher :sdwilsh]

(In reply to comment #12)
> same problem as this?
certainly possible!

Comment 14

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/mozilla-central/rev/d2a7652d726a

Comment 15

[Karl Tomlinson (:karlt)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/cad2c2f8140d