[HTML5] Remove <spacer> support

RESOLVED FIXED

Status

()

Core
HTML: Parser
P3
normal
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

Trunk
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
<spacer> support in gone in the spec. However, can't remove the parser support unless layout support is removed, too.
(Assignee)

Updated

8 years ago
Priority: -- → P3

Comment 1

7 years ago
I'm all for using better solutions than deprecated tags, but I thought we were keeping everything we already supported to not break compatibility with older sites?

See http://en.wikipedia.org/wiki/Comparison_of_layout_engines_%28Non-standard_HTML%29 for what we support that is deprecated.

Comment 2

7 years ago
Ah, I just saw bug 531030, and had missed that it was proprietary, not deprecated. As they say, kill it. But, there are still some inconsistencies in what we do, as you can see in the previous link. How about <blink>, <image>, <keygen> (now a HTML5 attribute?), <marquee> (probably a keeper since it's still pretty common in use), <nobr>, <noembed>, <nolayer> and <wbr>?
For what it's worth our <spacer> support currently breaks http://caribana.com/
In more detail,

They have code that does:

<td height="938" width="6"><spacer type="block" width="938"></td>

which causes a table cell to be much larger in Firefox than in other browsers. 

This code seems to come from Adobe PageMill

Comment 5

7 years ago
Allowing proprietary tags only in quirks mode is not an option?
(Assignee)

Comment 6

7 years ago
(In reply to comment #5)
> Allowing proprietary tags only in quirks mode is not an option?

Evidence (the behavior of other browsers) suggests that it's not needed, so there's no point in introducing that kind of complexity.

Assigning to self now that the layout side has been fixed.
Assignee: nobody → hsivonen
(Assignee)

Comment 7

7 years ago
Created attachment 473550 [details] [diff] [review]
Make the parser unaware of <spacer>

A test case will land as part of bug 559023.
Attachment #473550 - Flags: review?(jonas)
(Assignee)

Updated

7 years ago
Depends on: 559023
Attachment #473550 - Flags: review?(jonas) → review+
(Assignee)

Comment 8

7 years ago
Comment on attachment 473550 [details] [diff] [review]
Make the parser unaware of <spacer>

Requesting approval for 2.0: We already got rid of <spacer> layout support and this low-risk patch makes the parser match the spec on <spacer>. Taking this fix makes tracking standards-compliance easier, since the test between 2.0 and trunk wouldn't need to diverge if we had this patch on both.
Attachment #473550 - Flags: approval2.0?

Updated

7 years ago
Attachment #473550 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 9

7 years ago
http://hg.mozilla.org/mozilla-central/rev/bc15c280c430

As mentioned earlier, the test case is part of bug 559023.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED

Updated

7 years ago
Blocks: 597376

Updated

7 years ago
Whiteboard: [suspect-regress-dromaeo_dom]

Comment 10

7 years ago
A changeset from this bug was associated with a Dromaeo (DOM) regression. boo-urns :(

  Previous: avg 247.699 stddev 3.468 of 30 runs up to 268ef4ccb5ff
  New     : avg 238.140 stddev 1.402 of 5 runs since bc15c280c430
  Change  : -9.559 (-3.86% / z=2.756)
  Graph   : http://mzl.la/92KXJ4

The regression occurred from changesets in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=268ef4ccb5ff&tochange=bc15c280c430

The tag [suspect-regress-dromaeo_dom] has been added to the status whiteboard;
please remove it only once you have confirmed this bug is not the cause
of the regression.

Updated

7 years ago
Whiteboard: [suspect-regress-dromaeo_dom] → [suspect-regress-dromaeo_dom][suspect-regress-dromaeo_jslib]

Comment 11

7 years ago
A changeset from this bug was associated with a Dromaeo (jslib) regression. boo-urns :(

  Previous: avg 133.289 stddev 2.396 of 30 runs up to 268ef4ccb5ff
  New     : avg 123.541 stddev 0.943 of 5 runs since bc15c280c430
  Change  : -9.748 (-7.31% / z=4.068)
  Graph   : http://mzl.la/9hGqIo

The regression occurred from changesets in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=268ef4ccb5ff&tochange=bc15c280c430

The tag [suspect-regress-dromaeo_jslib] has been added to the status whiteboard;
please remove it only once you have confirmed this bug is not the cause
of the regression.
(Assignee)

Comment 12

7 years ago
The bot must be confusing this bug ith the other one in the same push: bug 531056.
(Assignee)

Comment 13

7 years ago
Doh. Bug 591981 that is.

Updated

7 years ago
Whiteboard: [suspect-regress-dromaeo_dom][suspect-regress-dromaeo_jslib] → [suspect-regress-dromaeo_dom][suspect-regress-dromaeo_jslib][suspect-regress-dromaeo_css]

Comment 14

7 years ago
A changeset from this bug was associated with a Dromaeo (CSS) regression. boo-urns :(

  Previous: avg 2081.901 stddev 35.646 of 30 runs up to 268ef4ccb5ff
  New     : avg 1986.498 stddev 14.409 of 5 runs since bc15c280c430
  Change  : -95.403 (-4.58% / z=2.676)
  Graph   : http://mzl.la/ba6Hsw

The regression occurred from changesets in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=268ef4ccb5ff&tochange=bc15c280c430

The tag [suspect-regress-dromaeo_css] has been added to the status whiteboard;
please remove it only once you have confirmed this bug is not the cause
of the regression.

Comment 15

7 years ago
A changeset from this bug was associated with a Dromaeo (DOM) regression. boo-urns :(

  Previous: avg 246.591 stddev 2.979 of 30 runs up to 268ef4ccb5ff
  New     : avg 233.803 stddev 2.192 of 5 runs since bc15c280c430
  Change  : -12.788 (-5.19% / z=4.292)
  Graph   : http://mzl.la/brFt7U

The regression occurred from changesets in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=268ef4ccb5ff&tochange=bc15c280c430

The tag [suspect-regress-dromaeo_dom] has been added to the status whiteboard;
please remove it only once you have confirmed this bug is not the cause
of the regression.

Comment 16

7 years ago
A changeset from this bug was associated with a Dromaeo (jslib) regression. boo-urns :(

  Previous: avg 130.889 stddev 2.485 of 30 runs up to 268ef4ccb5ff
  New     : avg 121.915 stddev 0.830 of 5 runs since bc15c280c430
  Change  : -8.975 (-6.86% / z=3.612)
  Graph   : http://mzl.la/bVrIoj

The regression occurred from changesets in the following range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=268ef4ccb5ff&tochange=bc15c280c430

The tag [suspect-regress-dromaeo_jslib] has been added to the status whiteboard;
please remove it only once you have confirmed this bug is not the cause
of the regression.
(Assignee)

Comment 17

7 years ago
There's no way the patch for this bug could have been the one causing the regression, since Dromaeo probably isn't stress-testing <spacer>.
Whiteboard: [suspect-regress-dromaeo_dom][suspect-regress-dromaeo_jslib][suspect-regress-dromaeo_css]
(Assignee)

Comment 18

7 years ago
Test landed as part of bug 559023.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.