53111 - Mailing List needs a different icon in results tree

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[Suresh]

Select a AB in the left pane. In the right pane, you will see the AB card and AB
lists are displayed in the same icon. Mailing lists needs a different icon.

Build and platform:
Today's commercial build on all platforms.

Comment 1

[Suresh]

Changing QA Contact.
fyi: There is a similar kinda bug - 26112. Not sure whether it is a same issue :)

Comment 2

[scottputterman]

reassigning to hewitt. I think Joe had mentioned turning these back on and the 
possibility of new icons.

Comment 3

[Joe Hewitt (gone)]

We do indeed have distinct icons in hand for mailing lists on both modern and
classic.

Comment 4

[fenella]

QA-assign-to fenella.

Comment 5

[jglick]

Attachment: The mailing list icon used in left pane but not in rt pane

Comment 6

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 7

[(not reading, please use [e-mail] instead)]

I've got the fix for this in my tree.  it's not a CSS issue.

I'll attach a screen shot.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

Comment 9

[(not reading, please use [e-mail] instead)]

patch coming, it will include this fix, and a fix for #105835, and some
performance  / cleanup changes. 

Comment 10

[(not reading, please use [e-mail] instead)]

Attachment: initial patch, include fix for #105835, clean up, performance fixes.

Comment 11

[Håkan Waara]

Comment on attachment 55283 [details] [diff] [review]
initial patch, include fix for #105835, clean up, performance fixes.

>+treeitem[empty="true"] > treerow > treecell > .tree-cell-twisty {               
>+  visibility: hidden;
>+}    
>+

Is this hack still valid?  We use outliners everywhere, 
so I doubt it is.

>+	if (name.Length() > 0) {
>+	  rv = createNode(name.get(), target);

Use if(!name.IsEmpty()) instead.

There are a bunch of tabs being added also...

Really nice cleanup.

Comment 12

[(not reading, please use [e-mail] instead)]

pushing this off.  

this fix will have to be redone, since we're switching to outliner.

>+treeitem[empty="true"] > treerow > treecell > .tree-cell-twisty 
{               
>+  visibility: hidden;
>+}    
>+

yes, it's needed for classic and modern.  there are trees in both products, 
account manager tree, pref tree, etc.

Comment 13

[(not reading, please use [e-mail] instead)]

fixed for both modern and classic as part of AB_OUTLINER_BRANCH landing.

Comment 14

[Ninoschka Baca]

Trunk build 2002-01-28-03: WinMe
Trunk build 2002-01-28-08: Linux RH 7.1
Trunk build 2002-01-28-08: Mac 10.1
Verified Fixed, using Modern and Classic.