Closed Bug 531158 Opened 11 years ago Closed 9 years ago

add support for IMAP ID extension rfc 2971

Categories

(MailNews Core :: Networking: IMAP, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 5.0b1

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

()

Details

Attachments

(1 file, 3 obsolete files)

The IMAP ID extension gives the client a way to identify itself to the server, mainly for statistical and bug-tracking reasons.  I think we should support this, probably with an opt-out pref. We already put the same information in the user-agent header.
Attached patch add support for ID command (obsolete) — Splinter Review
this sends the app name and version number to the server. We parse but ignore the response, which may contain information about the server. At some point, we may want to gather anonymous statistics about the hosts our users use.
Attached patch store id response as a pref (obsolete) — Splinter Review
this adds code to store the id response as a per-server pref. This could be useful for support issues, if we added the value of this pref to the about support output. The string pref is mail.server.serverX.serverIDResponse
Attachment #518897 - Attachment is obsolete: true
I'll need to add the ID command to the fake server before I can write a test for this...
Attached patch fix with unit test (obsolete) — Splinter Review
This adds a unit test, after adding support for the ID command to fakeserver. I had to move the getting of the xulappinfo to the UI thread in order for the xpcshell test to work, unfortunately.
Attachment #519018 - Attachment is obsolete: true
Attachment #519221 - Flags: review?(bugzilla)
Comment on attachment 519221 [details] [diff] [review]
fix with unit test

+static nsCString gAppName;
+static nsCString gAppVersion;

Static nsCStrings aren't allowed (memory leaks on shutdown).

In comment 0 you said about an opt-out pref, I don't see that in the code.

Did you also say to me at some stage that we basically send this information already to IMAP servers via a different method?
I can add an opt-out pref, but I can't imagine adding UI for it. Essentially it would be useful for the edge cases where the server advertises ID but doesn't handle it correctly.

I said that an IMAP server can essentially tell that it's talking to Thunderbird (or a derivative thereof) by the protocol pattern - it's essentially a fingerprint, and not really a secret, though it would require a bit of work.
added a hidden pref for turning this off, addressed other review comments.
Attachment #519221 - Attachment is obsolete: true
Attachment #530382 - Flags: review?(mbanner)
Attachment #519221 - Flags: review?(mbanner)
Comment on attachment 530382 [details] [diff] [review]
fix addressing comments

Review of attachment 530382 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine, we should probably get Neil to do a quick sr because of the minor api changes.
Attachment #530382 - Flags: superreview?(neil)
Attachment #530382 - Flags: review?(mbanner)
Attachment #530382 - Flags: review+
Attachment #530382 - Flags: superreview?(neil) → superreview+
fixed on trunk - http://hg.mozilla.org/comm-central/rev/a1c6b295010b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a4
You need to log in before you can comment on or make changes to this bug.