531231 - Incorrect mmap cleanup

Status: RESOLVED FIXED

(Core :: Networking: JAR, defect)

Comment 1

[(dormant account)]

Attachment: missing mmap cleanup

Comment 2

[(dormant account)]

Attachment: fix

Corrected the previous patch

Comment 3

[(dormant account)]

Timeless spotted this error. He also suggested the following MSDN link for guarding our io. I think that may be reasonable.

http://msdn.microsoft.com/en-us/library/aa366801%28VS.85%29.aspx

Comment 4

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/ce77c08f6dbf

Comment 5

[Reed Loden [:reed]]

Comment on attachment 414688 [details] [diff] [review]
fix

Requesting approval1.9.2 for this simple mmap fix when an OOM occurs.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 414688 [details] [diff] [review]
fix

a192=beltzner, post hoc, after scolding reed appropriately for landing without approval

Comment 7

[(dormant account)]

(In reply to comment #6)
> (From update of attachment 414688 [details] [diff] [review])
> a192=beltzner, post hoc, after scolding reed appropriately for landing without
> approval

Not sure how this is to land on 192 given that jar mmap code isn't landed there :)

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> Not sure how this is to land on 192 given that jar mmap code isn't landed there
> :)

Ah, I thought it had landed there, as per the bugs fixed on http://hg.mozilla.org/releases/mozilla-1.9.2/log/d7c3f3105089/modules/libjar/nsZipArchive.cpp (Bug 504864: mmap io for JARs). I didn't actually open it up on mxr to check, though.

Comment 9

[(dormant account)]

I was wrong, this fix needs to land in 192 too.

Comment 10

[(dormant account)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ab17a0719dfb