Closed
Bug 531283
Opened 15 years ago
Closed 15 years ago
Fix up building on 1.9.2 with jemalloc and allow building jemalloc with VC9 SP1
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.1a1
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
5.94 KB,
patch
|
Details | Diff | Splinter Review | |
6.25 KB,
patch
|
gozer
:
review+
|
Details | Diff | Splinter Review |
I was trying to test a patch against 1.9.2 and found out that jemalloc (our default config was broken).
The main reason for this is that we've picked up too much mozilla-central stuff (trying to link against mozcpp19 and not the appropriate msvc libs).
The patch I'm attaching fixes that, removes some of the 1.9.1 ifdefs which were around the build config glue that was related to the jemalloc changes, and ports bug 416117 so that we'll allow building jemalloc with 2008 SP1 not just 2005 SP1.
Assignee | ||
Comment 1•15 years ago
|
||
diff -w version of the patch
Assignee | ||
Updated•15 years ago
|
Attachment #414732 -
Flags: review?(gozer)
Assignee | ||
Comment 2•15 years ago
|
||
Comment on attachment 414732 [details] [diff] [review]
The fix (diff -w)
See other patch for non -w version.
This has built fine on Thunderbird try server with 1.9.2. It is currently building with trunk, so I won't push until it has finished and passed there (which I expect it to fine).
Updated•15 years ago
|
Attachment #414732 -
Flags: review?(gozer) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•