Fix up building on 1.9.2 with jemalloc and allow building jemalloc with VC9 SP1

RESOLVED FIXED in Thunderbird 3.1a1

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.1a1
All
Windows Server 2003
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 414731 [details] [diff] [review]
The fix

I was trying to test a patch against 1.9.2 and found out that jemalloc (our default config was broken).

The main reason for this is that we've picked up too much mozilla-central stuff (trying to link against mozcpp19 and not the appropriate msvc libs).

The patch I'm attaching fixes that, removes some of the 1.9.1 ifdefs which were around the build config glue that was related to the jemalloc changes, and ports bug 416117 so that we'll allow building jemalloc with 2008 SP1 not just 2005 SP1.
Created attachment 414732 [details] [diff] [review]
The fix (diff -w)

diff -w version of the patch
Attachment #414732 - Flags: review?(gozer)
Comment on attachment 414732 [details] [diff] [review]
The fix (diff -w)

See other patch for non -w version.

This has built fine on Thunderbird try server with 1.9.2. It is currently building with trunk, so I won't push until it has finished and passed there (which I expect it to fine).
Attachment #414732 - Flags: review?(gozer) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/13306556355f
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Depends on: 508861
You need to log in before you can comment on or make changes to this bug.